Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update depreciated type & fix nullable values #948

Closed
wants to merge 1 commit into from

Conversation

lohart13
Copy link

The allowed_passenger_identity_document_types field was depreciated in v2 so this has been updated to its updated field supported_passenger_identity_document_types with all its possible values as per the schema.

Also, the schema for order says all the passenger values are nullable but still exist in the response so this has been updated.
Also fare_type was missing from this so I've added it in.

@lohart13 lohart13 requested a review from a team as a code owner August 30, 2024 11:04
@igorp1
Copy link
Contributor

igorp1 commented Sep 6, 2024

This is a breaking change @lohart13, so we need to bump to the package to a new major version. I've made all the updates for v2 on #952. So feel free to close this one, it includes your changes.

@lohart13
Copy link
Author

Closed as per #952

@lohart13 lohart13 closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants