Client (high-level API) #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9259052264Details
💛 - Coveralls |
|
Merged all tasks so far! Now here comes the grand finale? :-) |
|
Merged all tasks so far! Now here comes the grand finale? :-)
Haha exactly. Let me rebase and clean a bit, I let you know when it is
ready for review and discussion.
|
feat: init Scheduler::run_task fn feat: ensure that Scheduler is Send fix: removed task utilities from Scheduler fix: adjust code after review feat: move run task to a dedicated Resolver init client workspace merge main + authenticate branches adjust code with new resolver api fix tasks re-export make fetch output hashmap keys return seq or uid
|
I think it is reviewable (just misses #193), but I don't know how to proceed. The file |
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 27, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 27, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 27, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 27, 2024
|
Closing in favour of https://github.com/soywod/imap-client. Code will adjust depending on your decisions (mostly talking about tasks). |
|
That was fast 🚀 |
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 29, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 29, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 29, 2024
soywod
added a commit
to pimalaya/imap-client
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite the fact that
imap-flowabstractions are really good (they give a lot of flexibility), I believe most of the casual users (including myself withemail-lib) do not care about this Sans IO abstraction. They just need a simple API where they can execute simple tasks, in serie. A bit like does theimapcrate.So far there is:
ClientFlow, the low-level flow for managing commandsScheduler, the mid-level flow for scheduling tasks, based onClientFlow(see also Task runner (mid-level API), part 1 #172)What I try to propose here is the high-level
Client, composed of aStreamandScheduler. Users could just connect to a server (TCP), ugrade to TLS and then execute actions likelist_capabilitiesorfetch.I would love feedback on the idea.