Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement read limit #153

Merged
merged 1 commit into from
Apr 21, 2024
Merged

feat: Implement read limit #153

merged 1 commit into from
Apr 21, 2024

Conversation

jakoschiko
Copy link
Collaborator

Relates to #87.

@coveralls
Copy link
Collaborator

coveralls commented Mar 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8591365856

Details

  • 69 of 144 (47.92%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 54.045%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/send_command.rs 7 12 58.33%
src/stream.rs 17 23 73.91%
src/receive.rs 9 17 52.94%
src/client.rs 15 35 42.86%
src/server.rs 14 50 28.0%
Files with Coverage Reduction New Missed Lines %
src/stream.rs 1 73.17%
Totals Coverage Status
Change from base Build 8582896757: 0.4%
Covered Lines: 648
Relevant Lines: 1199
💛 - Coveralls

@jakoschiko jakoschiko force-pushed the jakoschiko_read-limit branch from ea34aff to d656139 Compare March 20, 2024 00:03
@jakoschiko jakoschiko mentioned this pull request Apr 7, 2024
Open
@jakoschiko jakoschiko force-pushed the jakoschiko_read-limit branch from d656139 to 8a94dcd Compare April 7, 2024 17:03
@jakoschiko jakoschiko force-pushed the jakoschiko_read-limit branch from 8a94dcd to 3ec00a3 Compare April 7, 2024 20:19
@jakoschiko jakoschiko marked this pull request as ready for review April 7, 2024 20:20
@jakoschiko jakoschiko requested a review from duesee April 7, 2024 20:20
duesee
duesee approved these changes Apr 20, 2024
View reviewed changes
Copy link
Owner

@duesee duesee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's get this in.

@jakoschiko jakoschiko merged commit 8bf1f83 into main Apr 21, 2024
10 checks passed
@jakoschiko jakoschiko deleted the jakoschiko_read-limit branch April 21, 2024 17:42
@jakoschiko jakoschiko mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duesee duesee duesee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakoschiko @coveralls @duesee