Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate endless spinner on fincopilot.net #2791

Merged
merged 1 commit into from
Feb 27, 2025
Merged

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Feb 27, 2025

Asana Task/Github Issue: https://app.asana.com/0/1206670747178362/1209506643434365

Site breakage mitigation process:

Brief explanation

Reference

@laghee laghee added the SBT-PFM Site breakage mitigation that triggers asana-GH automation label Feb 27, 2025
@laghee laghee requested review from a team as code owners February 27, 2025 16:00
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

Generated file outputs:

Time updated: Thu, 27 Feb 2025 16:00:47 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (11 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -7934,8 +7934,9 @@
                                 "rule": "securepubads.g.doubleclick.net/tag/js/gpt.js",
                                 "domains": [
                                     "ah.nl",
                                     "applesfera.com",
+                                    "fincopilot.net",
                                     "goplay.be",
                                     "itsthevibe.com",
                                     "nytimes.com",
                                     "realmadrid.com",
@@ -7944,9 +7945,9 @@
                                     "stuff.co.nz",
                                     "wunderground.com",
                                     "youmath.it"
                                 ],
-                                "reason": "ah.nl - 'Bonus offer' elements do not render and are not clickable.,applesfera.com - https://github.com/duckduckgo/privacy-configuration/issues/1723,itsthevibe.com - https://github.com/duckduckgo/privacy-configuration/pull/2482,nytimes.com - https://github.com/duckduckgo/privacy-configuration/issues/1045,wunderground.com - Video element does not display.,youmath.it - Adwall displays which prevents page interaction and resets the page view when clicked.,rocketnews24.com - https://github.com/duckduckgo/privacy-configuration/issues/846,realmadrid.com - https://github.com/duckduckgo/privacy-configuration/issues/1683,stuff.co.nz - https://github.com/duckduckgo/privacy-configuration/issues/1740,goplay.be - https://github.com/duckduckgo/privacy-configuration/issues/1185,repretel.com - broken videos"
+                                "reason": "ah.nl - 'Bonus offer' elements do not render and are not clickable.,applesfera.com - https://github.com/duckduckgo/privacy-configuration/issues/1723,itsthevibe.com - https://github.com/duckduckgo/privacy-configuration/pull/2482,nytimes.com - https://github.com/duckduckgo/privacy-configuration/issues/1045,wunderground.com - Video element does not display.,youmath.it - Adwall displays which prevents page interaction and resets the page view when clicked.,rocketnews24.com - https://github.com/duckduckgo/privacy-configuration/issues/846,realmadrid.com - https://github.com/duckduckgo/privacy-configuration/issues/1683,stuff.co.nz - https://github.com/duckduckgo/privacy-configuration/issues/1740,goplay.be - https://github.com/duckduckgo/privacy-configuration/issues/1185,repretel.com - broken videos,fincopilot.net - https://github.com/duckduckgo/privacy-configuration/pull/2791"
                             },
                             {
                                 "rule": "securepubads.g.doubleclick.net/pagead/managed/js/gpt/.*/pubads_impl.js",
                                 "domains": [
v3/ios-config.json (1 more)
  • v3/ios-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -8193,8 +8193,9 @@
                                 "domains": [
                                     "ah.nl",
                                     "applesfera.com",
                                     "asuracomic.net",
+                                    "fincopilot.net",
                                     "goplay.be",
                                     "itsthevibe.com",
                                     "nytimes.com",
                                     "realmadrid.com",
@@ -8205,9 +8206,9 @@
                                     "uwbadgers.com",
                                     "wunderground.com",
                                     "youmath.it"
                                 ],
-                                "reason": "ah.nl - 'Bonus offer' elements do not render and are not clickable.,applesfera.com - https://github.com/duckduckgo/privacy-configuration/issues/1723,itsthevibe.com - https://github.com/duckduckgo/privacy-configuration/pull/2482,nytimes.com - https://github.com/duckduckgo/privacy-configuration/issues/1045,wunderground.com - Video element does not display.,youmath.it - Adwall displays which prevents page interaction and resets the page view when clicked.,rocketnews24.com - https://github.com/duckduckgo/privacy-configuration/issues/846,realmadrid.com - https://github.com/duckduckgo/privacy-configuration/issues/1683,stuff.co.nz - https://github.com/duckduckgo/privacy-configuration/issues/1740,goplay.be - https://github.com/duckduckgo/privacy-configuration/issues/1185,repretel.com - broken videos; solitaired.com - https://github.com/duckduckgo/privacy-configuration/pull/2329,uwbadgers.com - https://github.com/duckduckgo/privacy-configuration/issues/1593,asuracomic.net - https://github.com/duckduckgo/privacy-configuration/pull/2571"
+                                "reason": "ah.nl - 'Bonus offer' elements do not render and are not clickable.,applesfera.com - https://github.com/duckduckgo/privacy-configuration/issues/1723,itsthevibe.com - https://github.com/duckduckgo/privacy-configuration/pull/2482,nytimes.com - https://github.com/duckduckgo/privacy-configuration/issues/1045,wunderground.com - Video element does not display.,youmath.it - Adwall displays which prevents page interaction and resets the page view when clicked.,rocketnews24.com - https://github.com/duckduckgo/privacy-configuration/issues/846,realmadrid.com - https://github.com/duckduckgo/privacy-configuration/issues/1683,stuff.co.nz - https://github.com/duckduckgo/privacy-configuration/issues/1740,goplay.be - https://github.com/duckduckgo/privacy-configuration/issues/1185,repretel.com - broken videos,fincopilot.net - https://github.com/duckduckgo/privacy-configuration/pull/2791; solitaired.com - https://github.com/duckduckgo/privacy-configuration/pull/2329,uwbadgers.com - https://github.com/duckduckgo/privacy-configuration/issues/1593,asuracomic.net - https://github.com/duckduckgo/privacy-configuration/pull/2571"
                             },
                             {
                                 "rule": "securepubads.g.doubleclick.net/pagead/managed/js/gpt/.*/pubads_impl.js",
                                 "domains": [
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -7290,8 +7290,9 @@
                                 "rule": "securepubads.g.doubleclick.net/tag/js/gpt.js",
                                 "domains": [
                                     "ah.nl",
                                     "applesfera.com",
+                                    "fincopilot.net",
                                     "goplay.be",
                                     "itsthevibe.com",
                                     "nytimes.com",
                                     "realmadrid.com",

@laghee laghee enabled auto-merge February 27, 2025 18:46
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@laghee laghee added this pull request to the merge queue Feb 27, 2025
Merged via the queue into main with commit 16a7fd2 Feb 27, 2025
13 checks passed
@laghee laghee deleted the kate/fix-fincopilot branch February 27, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SBT-PFM Site breakage mitigation that triggers asana-GH automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants