Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable default browser prompts exp for internal users #2784

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LukasPaczos
Copy link

Asana Task/Github Issue: https://app.asana.com/0/0/1209506549129613

Description

Rolling out the linked experiment to internal users as a sanity check that everything goes smoothly.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

@LukasPaczos LukasPaczos requested review from a team as code owners February 26, 2025 16:35
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

@LukasPaczos LukasPaczos force-pushed the lukasz-p/default-browser-prompts-experiment/enable-internal branch from 6ed9517 to 1efe517 Compare February 26, 2025 16:36
Copy link

github-actions bot commented Feb 26, 2025

Generated file outputs:

Time updated: Thu, 27 Feb 2025 11:15:49 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json
--- v3/android-config.json
+++ v3/android-config.json
@@ -3155,8 +3155,40 @@
                 }
             },
             "exceptions": []
         },
+        "defaultBrowserPrompts": {
+            "state": "internal",
+            "exceptions": [],
+            "features": {
+                "defaultBrowserAdditionalPrompts202501": {
+                    "state": "internal",
+                    "settings": {
+                        "activeDaysUntilStage1": "1",
+                        "activeDaysUntilStage2": "4",
+                        "activeDaysUntilStop": "11"
+                    },
+                    "cohorts": [
+                        {
+                            "name": "control",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant1",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant2",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant3",
+                            "weight": 1
+                        }
+                    ]
+                }
+            }
+        },
         "duckPlayer": {
             "exceptions": [],
             "features": {
                 "pip": {
v3/extension-brave-config.json (12 more)
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -2128,8 +2128,12 @@
                 "betaEndingDescription": "The free, beta period is ending soon."
             },
             "minSupportedVersion": "0.64.0"
         },
+        "defaultBrowserPrompts": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "duckPlayer": {
             "exceptions": [],
             "features": {
                 "pip": {
latest
v4/android-config.json
--- v4/android-config.json
+++ v4/android-config.json
@@ -2764,8 +2764,40 @@
                 }
             },
             "exceptions": []
         },
+        "defaultBrowserPrompts": {
+            "state": "internal",
+            "exceptions": [],
+            "features": {
+                "defaultBrowserAdditionalPrompts202501": {
+                    "state": "internal",
+                    "settings": {
+                        "activeDaysUntilStage1": "1",
+                        "activeDaysUntilStage2": "4",
+                        "activeDaysUntilStop": "11"
+                    },
+                    "cohorts": [
+                        {
+                            "name": "control",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant1",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant2",
+                            "weight": 1
+                        },
+                        {
+                            "name": "variant3",
+                            "weight": 1
+                        }
+                    ]
+                }
+            }
+        },
         "duckPlayer": {
             "exceptions": [],
             "features": {
                 "pip": {
v4/extension-brave-config.json (12 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -1749,8 +1749,12 @@
                 "betaEndingDescription": "The free, beta period is ending soon."
             },
             "minSupportedVersion": "0.64.0"
         },
+        "defaultBrowserPrompts": {
+            "state": "disabled",
+            "exceptions": []
+        },
         "duckPlayer": {
             "exceptions": [],
             "features": {
                 "pip": {

@LukasPaczos LukasPaczos force-pushed the lukasz-p/default-browser-prompts-experiment/enable-internal branch from 1efe517 to 2dcab41 Compare February 27, 2025 10:33
@LukasPaczos LukasPaczos force-pushed the lukasz-p/default-browser-prompts-experiment/enable-internal branch from 2dcab41 to 8f74248 Compare February 27, 2025 11:15
@LukasPaczos LukasPaczos added the DO NOT MERGE Don't merge this branch unless directed label Feb 27, 2025
@LukasPaczos
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant