Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid triggering ad blocker wall on servustv.com #2772

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

kzar
Copy link
Collaborator

@kzar kzar commented Feb 21, 2025

It seems that CPM triggers the ad blocker wall for iOS users, and for Android
users triggers a redirection loop that entirely breaks the website. Also, on all
platforms it seems that blocking the https://dmp.theadex.com/d/1865/7400/s/adex.js
request also triggers the ad blocker wall as well.

Asana Task/Github Issue: https://app.asana.com/0/1206670747178362/1209461678993622

@kzar kzar added the SBT-PFM Site breakage mitigation that triggers asana-GH automation label Feb 21, 2025
@kzar kzar requested review from a team, muodov and sammacbeth as code owners February 21, 2025 15:08
Copy link

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Feb 21, 2025

Generated file outputs:

Time updated: Fri, 21 Feb 2025 15:14:02 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -672,8 +672,12 @@
                     "domain": "katieloxton.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2765"
                 },
                 {
+                    "domain": "servustv.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2772"
+                },
+                {
                     "domain": "marvel.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
                 },
                 {
@@ -10289,8 +10293,19 @@
                                 "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1588"
                             }
                         ]
                     },
+                    "theadex.com": {
+                        "rules": [
+                            {
+                                "rule": "dmp.theadex.com/",
+                                "domains": [
+                                    "servustv.com"
+                                ],
+                                "reason": "https://github.com/duckduckgo/privacy-configuration/pull/2772"
+                            }
+                        ]
+                    },
                     "theplatform.com": {
                         "rules": [
                             {
                                 "rule": "theplatform.com",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -553,8 +553,11 @@
                 {
                     "domain": "katieloxton.com"
                 },
                 {
+                    "domain": "servustv.com"
+                },
+                {
                     "domain": "marvel.com"
                 },
                 {
                     "domain": "sundancecatalog.com"
@@ -9414,8 +9417,18 @@
                                 ]
                             }
                         ]
                     },
+                    "theadex.com": {
+                        "rules": [
+                            {
+                                "rule": "dmp.theadex.com/",
+                                "domains": [
+                                    "servustv.com"
+                                ]
+                            }
+                        ]
+                    },
                     "theplatform.com": {
                         "rules": [
                             {
                                 "rule": "theplatform.com",

It seems that CPM triggers the ad blocker wall for iOS users, and for Android
users triggers a redirection loop that entirely breaks the website. Also, on all
platforms it seems that blocking the https://dmp.theadex.com/d/1865/7400/s/adex.js
request also triggers the ad blocker wall as well.
@kzar kzar force-pushed the kzar/servustv.com branch from 5f93e2d to 48f013e Compare February 21, 2025 15:12
@kzar kzar requested a review from tagawa February 21, 2025 15:14
@tagawa tagawa added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit a635e18 Feb 21, 2025
11 checks passed
@tagawa tagawa deleted the kzar/servustv.com branch February 21, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SBT-PFM Site breakage mitigation that triggers asana-GH automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants