Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autofill] Disable partial saves #2736

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Feb 7, 2025

Asana Task/Github Issue: https://app.asana.com/0/1203822806345703/1209282738083555

Description

Disabling partial_form_saves as a step to investigate drop in autofill accuracy metrics https://app.asana.com/0/1203822806345703/1209282738083555/f.

Feature change process:

  • I have added a schema to validate this feature change
  • I have tested this change locally
  • This code for the config change is ready to merge
  • This feature was covered by a tech design

Additional info:

  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • This code for the config change is ready
  • This change was covered by a ship review

Site breakage mitigation process:

Brief explanation

  • Reported URL:

  • Problems experienced:

  • Platforms affected:

    • iOS
    • Android
    • Windows
    • MacOS
    • Extensions
  • Tracker(s) being unblocked:

  • Feature being disabled:

  • I have referenced the URL of this PR as the "reason" value for the exception (where applicable).

  • This change is a speculative mitigation to fix reported breakage.

Reference

Copy link

github-actions bot commented Feb 7, 2025

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/disable-partial-save branch from dfbed34 to 08140b0 Compare February 7, 2025 04:31
Copy link

github-actions bot commented Feb 7, 2025

Generated file outputs:

Time updated: Fri, 07 Feb 2025 07:18:12 GMT

legacy
trackers-unprotected-temporary.txt (11 more)
  • trackers-unprotected-temporary.txt
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/windows-config.json

⚠️ File is identical

v3/android-config.json (2 more)
  • v3/android-config.json
  • v3/ios-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -823,9 +823,9 @@
                 "credentialsImportPromotionForExistingUsers": {
                     "state": "enabled"
                 },
                 "partialFormSaves": {
-                    "state": "enabled"
+                    "state": "disabled"
                 }
             }
         },
         "backgroundAgentPixelTest": {
latest
v4/android-config.json (2 more)
  • v4/android-config.json
  • v4/ios-config.json
  • v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -699,9 +699,9 @@
                 "credentialsImportPromotionForExistingUsers": {
                     "state": "enabled"
                 },
                 "partialFormSaves": {
-                    "state": "enabled"
+                    "state": "disabled"
                 }
             }
         },
         "backgroundAgentPixelTest": {
v4/extension-brave-config.json (10 more)
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/windows-config.json

⚠️ File is identical

@dbajpeyi dbajpeyi changed the title disable partial saves on Android [Autofill] Disable partial saves on Android Feb 7, 2025
@dbajpeyi dbajpeyi requested a review from CDRussell February 7, 2025 06:01
@dbajpeyi dbajpeyi marked this pull request as ready for review February 7, 2025 06:02
@dbajpeyi dbajpeyi requested review from a team as code owners February 7, 2025 06:02
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/disable-partial-save branch from 08140b0 to c4ffa2c Compare February 7, 2025 07:14
@dbajpeyi dbajpeyi requested a review from a team as a code owner February 7, 2025 07:14
@dbajpeyi dbajpeyi requested a review from studiosutara February 7, 2025 07:14
@dbajpeyi dbajpeyi changed the title [Autofill] Disable partial saves on Android [Autofill] Disable partial saves Feb 7, 2025
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/disable-partial-save branch from c4ffa2c to 3c7f863 Compare February 7, 2025 07:17
@CDRussell CDRussell added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit eda497a Feb 7, 2025
9 checks passed
@CDRussell CDRussell deleted the dbajpeyi/disable-partial-save branch February 7, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants