Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element hiding: address empty space above nav bar on abcnews.go.com #2731

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

dharb
Copy link
Collaborator

@dharb dharb commented Feb 6, 2025

Asana Task/Github Issue: https://app.asana.com/0/1206670747178362/1209238322357549

Description

The navigation bar on https://abcnews.go.com is shifted down from the top of the page in order to display an ad (which doesn't load due to trackers). This PR addresses that empty space.

@dharb dharb requested review from jonathanKingston and a team as code owners February 6, 2025 16:10
@dharb dharb enabled auto-merge February 6, 2025 16:10
Copy link

github-actions bot commented Feb 6, 2025

Don't forget to add an individual reviewer (in addition to those already added, this should create a task for them in Asana).
- The best reviewer is most likely a feature or platform owner.
- If they've got permission to approve, you're good to merge. See CODEOWNERS
- As a fallback the Global owners are:
- Breakage AOR
- Breakage triagers
- Config AOR
Please mark this as draft unless there's intention to merge this.
Click the "Merge When Ready" if you're happy for this to automatically get merged once reviewed.
- If the option isn't available to you; ensure you've signed into DuckDuckGo oauth.
Also don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Feb 6, 2025

Generated file outputs:

Time updated: Thu, 06 Feb 2025 16:11:09 GMT

legacy
trackers-unprotected-temporary.txt

⚠️ File is identical

v3/android-config.json (13 more)
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -2838,8 +2838,23 @@
                             }
                         ]
                     },
                     {
+                        "domain": "abcnews.go.com",
+                        "rules": [
+                            {
+                                "selector": ".navigation",
+                                "type": "modify-style",
+                                "values": [
+                                    {
+                                        "property": "top",
+                                        "value": "0px"
+                                    }
+                                ]
+                            }
+                        ]
+                    },
+                    {
                         "domain": "accuweather.com",
                         "rules": [
                             {
                                 "selector": ".glacier-ad",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -2459,8 +2459,23 @@
                             }
                         ]
                     },
                     {
+                        "domain": "abcnews.go.com",
+                        "rules": [
+                            {
+                                "selector": ".navigation",
+                                "type": "modify-style",
+                                "values": [
+                                    {
+                                        "property": "top",
+                                        "value": "0px"
+                                    }
+                                ]
+                            }
+                        ]
+                    },
+                    {
                         "domain": "accuweather.com",
                         "rules": [
                             {
                                 "selector": ".glacier-ad",

@dharb dharb requested a review from sammacbeth February 6, 2025 16:41
@dharb dharb added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit a260a4b Feb 6, 2025
12 of 13 checks passed
@dharb dharb deleted the dharb/eh-abcnews branch February 6, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants