Enable PiP button in DuckPlayer #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakyShane
approved these changes
Jun 14, 2024
shakyShane
added a commit
that referenced
this pull request
Jun 14, 2024
* add initial data to duckplayer page * opt-out of the extract retry loop * Enable PiP button in DuckPlayer (#973) * Enable pip button in duckplayer * fix an exception in the DuckPlayer integration test * Remove redundant console logs * Lint fix * Fix integration tests for duckplayer * rename to 'state' --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com> --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com> Co-authored-by: Maxim Tsoy <mtsoy@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/42792087274227/1207467022608818/f