Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: more SR feedback #1449

Merged
merged 2 commits into from
Feb 3, 2025
Merged

ntp: more SR feedback #1449

merged 2 commits into from
Feb 3, 2025

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Feb 2, 2025

Asana Task/Github Issue: https://app.asana.com/0/1201141132935289/1209300015210566

Description

  • fixed a few small UI issues and missing pieces
    • please see the inline code comments for details.

Testing Steps

  • Visit the preview URLs as usual

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Feb 2, 2025

Copy link

github-actions bot commented Feb 2, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Feb 2, 2025

[Beta] Generated file diff

Time updated: Mon, 03 Feb 2025 11:02:28 GMT

Integration
    - integration/pages/new-tab/dist/index.css
  • integration/pages/new-tab/dist/index.js

File has changed

Windows
    - windows/pages/new-tab/dist/index.css
  • windows/pages/new-tab/dist/index.js

File has changed

Apple
    - dist/pages/new-tab/dist/index.css
  • dist/pages/new-tab/dist/index.js

File has changed

@shakyShane shakyShane marked this pull request as ready for review February 2, 2025 22:15
@shakyShane shakyShane requested review from mgurgel and a team as code owners February 2, 2025 22:15
Base automatically changed from 02-02-ntp_activity_schema_burn_animation to main February 3, 2025 10:59
@shakyShane shakyShane force-pushed the 02-02-ntp_more_sr_feedback branch from 99be892 to 29a0ce7 Compare February 3, 2025 11:01
Copy link

netlify bot commented Feb 3, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 29a0ce7
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/67a0a2115f81dd0008c26590
😎 Deploy Preview https://deploy-preview-1449--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@mgurgel mgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@shakyShane shakyShane merged commit 981844a into main Feb 3, 2025
13 checks passed
@shakyShane shakyShane deleted the 02-02-ntp_more_sr_feedback branch February 3, 2025 11:14
mgurgel pushed a commit that referenced this pull request Feb 3, 2025
* ntp: more SR feedback

* simpler company icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants