Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntp: include apple #1181

Merged
merged 2 commits into from
Nov 5, 2024
Merged

ntp: include apple #1181

merged 2 commits into from
Nov 5, 2024

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 31, 2024

Asana Task/Github Issue: https://app.asana.com/0/1201048563534612/1208697680654248/f

Description

  • include NTP on Apple Platforms

Testing Steps

  • None

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 31, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 09b4109
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/672a2e46cd7c76000815f717
😎 Deploy Preview https://deploy-preview-1181--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 31, 2024

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 31, 2024

[Beta] Generated file diff

Time updated: Tue, 05 Nov 2024 14:41:06 GMT

New Files
    - dist/pages/new-tab/company-icons/33across.svg
  • dist/pages/new-tab/company-icons/a.svg
  • dist/pages/new-tab/company-icons/acuityads.svg
  • dist/pages/new-tab/company-icons/adform.svg
  • dist/pages/new-tab/company-icons/adjust.svg
  • dist/pages/new-tab/company-icons/adobe.svg
  • dist/pages/new-tab/company-icons/akamai.svg
  • dist/pages/new-tab/company-icons/amazon.svg
  • dist/pages/new-tab/company-icons/amplitude.svg
  • dist/pages/new-tab/company-icons/appsflyer.svg
  • dist/pages/new-tab/company-icons/automattic.svg
  • dist/pages/new-tab/company-icons/b.svg
  • dist/pages/new-tab/company-icons/beeswax.svg
  • dist/pages/new-tab/company-icons/bidtellect.svg
  • dist/pages/new-tab/company-icons/branch-metrics.svg
  • dist/pages/new-tab/company-icons/braze.svg
  • dist/pages/new-tab/company-icons/bugsnag.svg
  • dist/pages/new-tab/company-icons/bytedance.svg
  • dist/pages/new-tab/company-icons/c.svg
  • dist/pages/new-tab/company-icons/chartbeat.svg
  • dist/pages/new-tab/company-icons/cloudflare.svg
  • dist/pages/new-tab/company-icons/cognitiv.svg
  • dist/pages/new-tab/company-icons/comscore.svg
  • dist/pages/new-tab/company-icons/crimtan-holdings.svg
  • dist/pages/new-tab/company-icons/criteo.svg
  • dist/pages/new-tab/company-icons/d.svg
  • dist/pages/new-tab/company-icons/deepintent.svg
  • dist/pages/new-tab/company-icons/e.svg
  • dist/pages/new-tab/company-icons/exoclick.svg
  • dist/pages/new-tab/company-icons/eyeota.svg
  • dist/pages/new-tab/company-icons/f.svg
  • dist/pages/new-tab/company-icons/facebook.svg
  • dist/pages/new-tab/company-icons/g.svg
  • dist/pages/new-tab/company-icons/google-ads.svg
  • dist/pages/new-tab/company-icons/google-analytics.svg
  • dist/pages/new-tab/company-icons/google.svg
  • dist/pages/new-tab/company-icons/gumgum.svg
  • dist/pages/new-tab/company-icons/h.svg
  • dist/pages/new-tab/company-icons/hotjar.svg
  • dist/pages/new-tab/company-icons/i.svg
  • dist/pages/new-tab/company-icons/id5.svg
  • dist/pages/new-tab/company-icons/improve-digital.svg
  • dist/pages/new-tab/company-icons/index-exchange.svg
  • dist/pages/new-tab/company-icons/inmar.svg
  • dist/pages/new-tab/company-icons/instagram.svg
  • dist/pages/new-tab/company-icons/intent-iq.svg
  • dist/pages/new-tab/company-icons/iponweb.svg
  • dist/pages/new-tab/company-icons/j.svg
  • dist/pages/new-tab/company-icons/k.svg
  • dist/pages/new-tab/company-icons/kargo.svg
  • dist/pages/new-tab/company-icons/kochava.svg
  • dist/pages/new-tab/company-icons/l.svg
  • dist/pages/new-tab/company-icons/line.svg
  • dist/pages/new-tab/company-icons/linkedin.svg
  • dist/pages/new-tab/company-icons/liveintent.svg
  • dist/pages/new-tab/company-icons/liveramp.svg
  • dist/pages/new-tab/company-icons/loopme-ltd.svg
  • dist/pages/new-tab/company-icons/lotame-solutions.svg
  • dist/pages/new-tab/company-icons/m.svg
  • dist/pages/new-tab/company-icons/magnite.svg
  • dist/pages/new-tab/company-icons/mediamath.svg
  • dist/pages/new-tab/company-icons/medianet-advertising.svg
  • dist/pages/new-tab/company-icons/mediavine.svg
  • dist/pages/new-tab/company-icons/merkle.svg
  • dist/pages/new-tab/company-icons/microsoft.svg
  • dist/pages/new-tab/company-icons/mixpanel.svg
  • dist/pages/new-tab/company-icons/n.svg
  • dist/pages/new-tab/company-icons/narrative.svg
  • dist/pages/new-tab/company-icons/nativo.svg
  • dist/pages/new-tab/company-icons/neustar.svg
  • dist/pages/new-tab/company-icons/new-relic.svg
  • dist/pages/new-tab/company-icons/o.svg
  • dist/pages/new-tab/company-icons/onetrust.svg
  • dist/pages/new-tab/company-icons/openjs-foundation.svg
  • dist/pages/new-tab/company-icons/openx.svg
  • dist/pages/new-tab/company-icons/opera-software.svg
  • dist/pages/new-tab/company-icons/oracle.svg
  • dist/pages/new-tab/company-icons/other.svg
  • dist/pages/new-tab/company-icons/outbrain.svg
  • dist/pages/new-tab/company-icons/p.svg
  • dist/pages/new-tab/company-icons/pinterest.svg
  • dist/pages/new-tab/company-icons/prospect-one.svg
  • dist/pages/new-tab/company-icons/pubmatic.svg
  • dist/pages/new-tab/company-icons/pulsepoint.svg
  • dist/pages/new-tab/company-icons/q.svg
  • dist/pages/new-tab/company-icons/quantcast.svg
  • dist/pages/new-tab/company-icons/r.svg
  • dist/pages/new-tab/company-icons/rhythmone.svg
  • dist/pages/new-tab/company-icons/roku.svg
  • dist/pages/new-tab/company-icons/rtb-house.svg
  • dist/pages/new-tab/company-icons/rubicon.svg
  • dist/pages/new-tab/company-icons/s.svg
  • dist/pages/new-tab/company-icons/salesforce.svg
  • dist/pages/new-tab/company-icons/semasio.svg
  • dist/pages/new-tab/company-icons/sharethrough.svg
  • dist/pages/new-tab/company-icons/simplifi-holdings.svg
  • dist/pages/new-tab/company-icons/smaato.svg
  • dist/pages/new-tab/company-icons/snap.svg
  • dist/pages/new-tab/company-icons/sonobi.svg
  • dist/pages/new-tab/company-icons/sovrn-holdings.svg
  • dist/pages/new-tab/company-icons/spotx.svg
  • dist/pages/new-tab/company-icons/supership.svg
  • dist/pages/new-tab/company-icons/synacor.svg
  • dist/pages/new-tab/company-icons/t.svg
  • dist/pages/new-tab/company-icons/taboola.svg
  • dist/pages/new-tab/company-icons/tapad.svg
  • dist/pages/new-tab/company-icons/teads.svg
  • dist/pages/new-tab/company-icons/the-nielsen-company.svg
  • dist/pages/new-tab/company-icons/the-trade-desk.svg
  • dist/pages/new-tab/company-icons/triplelift.svg
  • dist/pages/new-tab/company-icons/twitter.svg
  • dist/pages/new-tab/company-icons/u.svg
  • dist/pages/new-tab/company-icons/unruly-group.svg
  • dist/pages/new-tab/company-icons/urban-airship.svg
  • dist/pages/new-tab/company-icons/v.svg
  • dist/pages/new-tab/company-icons/verizon-media.svg
  • dist/pages/new-tab/company-icons/w.svg
  • dist/pages/new-tab/company-icons/warnermedia.svg
  • dist/pages/new-tab/company-icons/wpp.svg
  • dist/pages/new-tab/company-icons/x.svg
  • dist/pages/new-tab/company-icons/xaxis.svg
  • dist/pages/new-tab/company-icons/y.svg
  • dist/pages/new-tab/company-icons/yahoo-japan.svg
  • dist/pages/new-tab/company-icons/yandex.svg
  • dist/pages/new-tab/company-icons/yieldmo.svg
  • dist/pages/new-tab/company-icons/youtube.svg
  • dist/pages/new-tab/company-icons/z.svg
  • dist/pages/new-tab/company-icons/zeotap.svg
  • dist/pages/new-tab/company-icons/zeta-global.svg
  • dist/pages/new-tab/icons/Announce.svg
  • dist/pages/new-tab/icons/AppUpdate.svg
  • dist/pages/new-tab/icons/CriticalUpdate.svg
  • dist/pages/new-tab/icons/DDGAnnounce.svg
  • dist/pages/new-tab/icons/PrivacyPro.svg
  • dist/pages/new-tab/icons/ddg-favicon.png
  • dist/pages/new-tab/icons/favicon@2x.png
  • dist/pages/new-tab/icons/shield.svg
  • dist/pages/new-tab/index.html
  • dist/pages/new-tab/js/index.css
  • dist/pages/new-tab/js/index.js
  • dist/pages/new-tab/js/inline.js
  • dist/pages/new-tab/js/mock-transport.js
  • dist/pages/new-tab/letters/a.svg
  • dist/pages/new-tab/letters/b.svg
  • dist/pages/new-tab/letters/c.svg
  • dist/pages/new-tab/letters/d.svg
  • dist/pages/new-tab/letters/e.svg
  • dist/pages/new-tab/letters/f.svg
  • dist/pages/new-tab/letters/g.svg
  • dist/pages/new-tab/letters/h.svg
  • dist/pages/new-tab/letters/i.svg
  • dist/pages/new-tab/letters/j.svg
  • dist/pages/new-tab/letters/k.svg
  • dist/pages/new-tab/letters/l.svg
  • dist/pages/new-tab/letters/m.svg
  • dist/pages/new-tab/letters/n.svg
  • dist/pages/new-tab/letters/o.svg
  • dist/pages/new-tab/letters/p.svg
  • dist/pages/new-tab/letters/q.svg
  • dist/pages/new-tab/letters/r.svg
  • dist/pages/new-tab/letters/s.svg
  • dist/pages/new-tab/letters/t.svg
  • dist/pages/new-tab/letters/u.svg
  • dist/pages/new-tab/letters/v.svg
  • dist/pages/new-tab/letters/w.svg
  • dist/pages/new-tab/letters/x.svg
  • dist/pages/new-tab/letters/y.svg
  • dist/pages/new-tab/letters/z.svg
  • dist/pages/new-tab/locales/en/newtab.json

❌ File only exists in new changeset

@shakyShane shakyShane force-pushed the 10-31-ntp_include_apple branch from c72a7f5 to 0ade20c Compare November 4, 2024 13:39
@shakyShane shakyShane changed the base branch from main to extract_entry_points November 4, 2024 13:39
@shakyShane shakyShane force-pushed the extract_entry_points branch from b4ab524 to e9d7b4a Compare November 4, 2024 14:07
@shakyShane shakyShane force-pushed the 10-31-ntp_include_apple branch from 0ade20c to f444b8c Compare November 4, 2024 14:07
Base automatically changed from extract_entry_points to main November 4, 2024 14:43
@shakyShane shakyShane force-pushed the 10-31-ntp_include_apple branch from f444b8c to 266078e Compare November 5, 2024 14:37
@shakyShane shakyShane marked this pull request as ready for review November 5, 2024 14:37
@shakyShane shakyShane requested review from mgurgel and a team as code owners November 5, 2024 14:37
@shakyShane shakyShane merged commit 443a70a into main Nov 5, 2024
14 checks passed
@shakyShane shakyShane deleted the 10-31-ntp_include_apple branch November 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants