Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use approximate location permission #5665

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Feb 18, 2025

Task/Issue URL: https://app.asana.com/0/1205648422731273/1209434223230239

Description

Steps to test this PR

Grant approximate location permission

  • Fresh install and visit permission.site
  • Ask for Location permissions
  • Verify Location dialog appears
  • Allow permissions
  • Verify system dialog is shown
  • Allow access to approximate location
  • Verify location is granted (location button is green)

Verify SERP can access approximate location

  • Fresh install and search for "cafe nearby"
  • Verify Location dialog appears
  • Deny permissions
  • Verify results are based on IP geolocation and there is no blue dot on the map indicating your position
    • You might want to use VPN to be able to easily tell the difference between IP geolocation and real approximate location
  • Tap on the location icon in the top right corner of the map
  • Tap "use location"
  • Verify Location dialog appears
  • Allow permissions
  • Verify system dialog is shown
  • Allow access to approximate location
  • Verify that map has reloaded and your approximate location is marked with a blue dot.

Check following scenarios for regression - no behavior changes are expected

Precise location permission granted

  • Fresh install and visit permission.site
  • Ask for Location permissions
  • Verify Location dialog appears
  • Allow permissions
  • Verify system dialog is shown
  • Allow access to precise location
  • Verify location is granted (location button is green)

Location permission not granted

  • Fresh install and visit permission.site
  • Ask for Location permissions
  • Verify Location dialog appears
  • Deny permissions
  • Verify location is not granted (location button is red)

Location permission granted (not system granted)

  • Fresh install and visit permission.site
  • Ask for Location permissions
  • Verify Location dialog appears
  • Allow permissions
  • Verify system dialog is shown
  • Deny permissions
  • Verify location is not granted (location button is red)
  • Verify Snackbar appears
  • Ask for Location permissions
  • Verify system dialog is shown
  • Deny permissions
  • Verify Settings dialog appears
  • Tap on Open Settings
  • Verify Device Settings screen opens

No UI changes

Copy link
Contributor Author

lmac012 commented Feb 18, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 marked this pull request as ready for review February 19, 2025 13:58
@lmac012 lmac012 requested a review from nalcalag February 20, 2025 15:20
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected 💯 Thanks a lot for fixing this @lmac012

@lmac012 lmac012 merged commit fea8ede into develop Feb 21, 2025
6 checks passed
@lmac012 lmac012 deleted the fix/lukasz/approximate-location-permission branch February 21, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants