Additional "default browser" prompts: enroll only onboarded users #5523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a97b9f to
6c7a3cd
Compare
a63c7ff to
e002bd3
Compare
malmstein
approved these changes
Jan 28, 2025
| @@ -154,9 +165,10 @@ class DefaultBrowserPromptsExperimentImpl @Inject constructor( | |||
| } | |||
|
|
|||
| private suspend fun evaluate() { | |||
| val isOnboardingComplete = userStageStore.getUserAppStage() == AppStage.ESTABLISHED | |||
There was a problem hiding this comment.
Has @nalcalag looked at this? In the past we’ve had issues understanding if onboarding was complete in some edge cases, so just want to double check.
There was a problem hiding this comment.
Thanks for the heads-up @malmstein . This check is correct, when onboarding is completed, the UserAppStage should be set to ESTABLISHED. This means all onboarding dialogs, both in-context and on the new tab page, will have already been shown.
There are other methods to determine if parts of the onboarding process have been completed, such as checking for dialogs on the new tab page, etc. I’m not sure about the specific requirements for this feature, but feel free to reach out to me if needed @LukasPaczos .
1397fda to
cc2c9a8
Compare
Base automatically changed from
feature/lukasz-p/default-browser-prompts-variant-2
to
develop
January 31, 2025 13:32
e002bd3 to
bc30cad
Compare
bc30cad to
58b330f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208671518894266/1209220388656415/f
Description
We only want to enroll users that are already onboarded and have seen the default browser prompt that's part of onboarding.
Steps to test this PR
You can follow instructions from #5476 but when you're in the onboarding experience, minimize the app, change the date forward, and resume the app. Previously the experiment's default browser dialog would show, with the proposed changes it won't, because we're only enrolling users after onboarding is done.