Show Not now as secondary button during autofill onboarding #5198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @cmonfortep and the rest of your teammates on |
CDRussell
approved these changes
Oct 29, 2024
7957646 to
b52386f
Compare
b52386f to
0629382
Compare
Task/Issue URL: https://app.asana.com/0/1149059203486286/1208634215033039/f ### Description Request translations from Smartling for secondary button ### Steps to test this PR N/A ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
aitorvs
pushed a commit
that referenced
this pull request
Nov 6, 2024
Task/Issue URL: https://app.asana.com/0/1203822806345703/1208592982102639/f ### Description During Autofill Onboarding show "Not Now" as secondary button. ### Steps to test this PR _Feature 1_ - [x] fresh install - [x] visit fill.dev and try a login - [x] ensure on the dialog (onboarding), secondary button is not now - [x] click Not Now - [x] visit authenticationtest.com and try a login - [x] ensure on the dialog (onboarding), secondary - [x] click not now - [x] visit fill.dev again and try a login - [x] ensure on the dialog (not onboarding anymote), secondary button is Never for this site ### UI changes | Before | After | | ------ | ----- | !(Upload before screenshot)|(Upload after screenshot)| --------- Co-authored-by: Dax The Translator <daxmobile@duckduckgo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203822806345703/1208592982102639/f
Description
During Autofill Onboarding show "Not Now" as secondary button.
Steps to test this PR
Feature 1
UI changes