Fix omnibar scrolling and browser layout gap

[0nko]

Task/Issue URL: https://app.asana.com/0/488551667048375/1208503210252671/f
Also: https://app.asana.com/0/488551667048375/1208503210253722/f.

Description

This PR fixes 2 connected issues:

• A gap at the bottom of a screen is visible when scroll flags are set on a toolbar container to disable toolbar scrolling
• Bottom omnibar not visible or is incorrectly scrollable while an omnibar icon is highlighted

The solution unifies how the scrolling is enabled/disabled for both the top and bottom bar. The scroll flags are not set anymore, which fixes the gap problem.

Steps to test this PR

Bottom bar scrolling with highlighted icons

• Clear the app storage and run the app
• Set the omnibar position to bottom
• Go through the onboarding steps until you get to the blocked trackers
• Notice that when the shield is highlighted, the omnibar is expanded and not scrollable
• After completing the onboarding, notice that the omnibar is scrollable again

Extra gap at the bottom

• Clear the app storage and run the app
• Go through the onboarding steps until you get to the blocked trackers
• Notice there is no gap at the bottom

UI changes

Bottom bar scrolling with highlighted icons

Screen_recording_20241012_165918.mp4

Extra gap at the bottom

Screen_recording_20241012_165828.mp4

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1208503210252671

[nalcalag]

@0nko I've been testing this and although the bugs seem to be fixed 🎉 . There is a padding added to the top of the bottom address bar that is visible when a Dax dialog is shown in the New Tab Page. See video attached.

Screen_recording_20241014_092705.mp4

[0nko]

Thanks for the review @nalcalag! I added a change that fixes the issue. Ready for another round!

[nalcalag]

LGTM! All bugs are fixed 💯