Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt autocomplete item to system font size #4588

Merged
merged 1 commit into from
May 31, 2024

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented May 26, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207407556106269/f

Description

Fixes the issue reported in #4564

Steps to test this PR

  • Change the system font size to the largest option.
  • Type a word in the search bar.
  • Verify that the autocomplete item text is not clipped off.

(Tested on a Pixel 2, Android 11)

UI changes

scaled_autocomplete_item

@joshliebe
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite Graphite

@nalcalag nalcalag self-assigned this May 31, 2024
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@joshliebe joshliebe merged commit ed999f2 into develop May 31, 2024
7 checks passed
@joshliebe joshliebe deleted the feature/josh/wrap-autocomplete-text branch May 31, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants