Update worflows with new onboarding (#5592)

Task/Issue URL: https://app.asana.com/0/1201807753394693/1209308863210226 ### Description After merging a new onboarding flow, most of our workflows are broken as they are missing one step ### Steps to test this PR - [ ] Run maestro tests - [ ] Check they pass ### No UI changes --------- Co-authored-by: Craig Russell <1336281+CDRussell@users.noreply.github.com>
duckduckgo · Feb 4, 2025 · 44481cb · 44481cb
1 parent 397271f
commit 44481cb
Show file tree

Hide file tree

Showing 65 changed files with 118 additions and 117 deletions.
diff --git a/...ection_flows/10_-_m.js_bing-provided_ad_domain_provided_but_incorrect_dsl_not_needed.yaml b/...ection_flows/10_-_m.js_bing-provided_ad_domain_provided_but_incorrect_dsl_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-10"
       - pressKey: Enter

diff --git a/...js_bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf_u3_not_needed.yaml b/...js_bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf_u3_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-11"
       - pressKey: Enter

diff --git a/..._bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf__dsl_not_needed.yaml b/..._bing-provided_ad_domain_provided_but_it's_not_a_domain_i.e.,_abcedf__dsl_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-12"
       - pressKey: Enter

diff --git a/...d_but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site_u3_not_needed.yaml b/...d_but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site_u3_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-13"
       - pressKey: Enter

diff --git a/...but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site__dsl_not_needed.yaml b/...but_it's_a_subdomain_of_advertiser_i.e.,_foo.www.search-company-site__dsl_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-14"
       - pressKey: Enter

diff --git a/..._click_detection_flows/1_-_y.js_heuristic_no_ad_domain_param_u3_param_included_1_1_1.yaml b/..._click_detection_flows/1_-_y.js_heuristic_no_ad_domain_param_u3_param_included_1_1_1.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-1"
       - pressKey: Enter

diff --git a/...d_click_detection_flows/2_-_m.js_heuristic_no_ad_domain_param_dsl_param_included_1_1.yaml b/...d_click_detection_flows/2_-_m.js_heuristic_no_ad_domain_param_dsl_param_included_1_1.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-2"
       - pressKey: Enter

diff --git a/...lick_detection_flows/3_-_y.js_heuristic_no_ad_domain_param,_but_missing_u3_param_1_1.yaml b/...lick_detection_flows/3_-_y.js_heuristic_no_ad_domain_param,_but_missing_u3_param_1_1.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-3"
       - pressKey: Enter

diff --git a/...ick_detection_flows/4_-_m.js_heuristic_no_ad_domain_param,_but_missing_dsl_param_1_1.yaml b/...ick_detection_flows/4_-_m.js_heuristic_no_ad_domain_param,_but_missing_dsl_param_1_1.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-4"
       - pressKey: Enter

diff --git a/...click_detection_flows/5_-_y.js_heuristic_ad_domain_provided,_but_empty_u3_not_needed.yaml b/...click_detection_flows/5_-_y.js_heuristic_ad_domain_provided,_but_empty_u3_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-5"
       - pressKey: Enter

diff --git a/...lick_detection_flows/6_-_m.js_heuristic_ad_domain_provided,_but_empty_dsl_not_needed.yaml b/...lick_detection_flows/6_-_m.js_heuristic_ad_domain_provided,_but_empty_dsl_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-6"
       - pressKey: Enter

diff --git a/...tro/ad_click_detection_flows/7_-_y.js_bing-provided_ad_domain_provided_u3_not_needed.yaml b/...tro/ad_click_detection_flows/7_-_y.js_bing-provided_ad_domain_provided_u3_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-6" # scroll until the ad-id-6 instead of ad-id-7 (context: https://app.asana.com/0/0/1204397066248823/1204415854211764/f)
       - pressKey: Enter

diff --git a/...ro/ad_click_detection_flows/8_-_m.js_bing-provided_ad_domain_provided_dsl_not_needed.yaml b/...ro/ad_click_detection_flows/8_-_m.js_bing-provided_ad_domain_provided_dsl_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-8"
       - pressKey: Enter

diff --git a/...etection_flows/9_-_y.js_bing-provided_ad_domain_provided_but_incorrect_u3_not_needed.yaml b/...etection_flows/9_-_y.js_bing-provided_ad_domain_provided_but_incorrect_u3_not_needed.yaml
@@ -8,7 +8,7 @@ tags:
       - launchApp:
           clearState: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - inputText: "https://www.search-company.site/#ad-id-9"
       - pressKey: Enter

diff --git a/.maestro/ads_preview_flows/1-_design-system-components.yaml b/.maestro/ads_preview_flows/1-_design-system-components.yaml
@@ -9,7 +9,7 @@ tags:
             clearState: true
             stopApp: true
 
-        - runFlow: ../shared/onboarding.yaml
+        - runFlow: ../shared/pre_onboarding.yaml
 
         - tapOn:
             id: "com.duckduckgo.mobile.android:id/browserMenuImageView"

diff --git a/.maestro/app_tp/app_tp_onboarding.yaml b/.maestro/app_tp/app_tp_onboarding.yaml
@@ -10,7 +10,7 @@ tags:
               clearState: true
               stopApp: true
 
-        - runFlow: ../shared/onboarding.yaml
+        - runFlow: ../shared/pre_onboarding.yaml
 
         - tapOn:
             id: "com.duckduckgo.mobile.android:id/browserMenuImageView"

diff --git a/.maestro/autofill/1_autofill_shown_in_overflow.yaml b/.maestro/autofill/1_autofill_shown_in_overflow.yaml
@@ -10,5 +10,5 @@ tags:
     commands:
       - launchApp:
             clearState: true
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
       - runFlow: steps/access_passwords_screen.yaml
diff --git a/.maestro/autofill/2_autofill_add_search_update_delete_creds.yaml b/.maestro/autofill/2_autofill_add_search_update_delete_creds.yaml
@@ -9,7 +9,7 @@ tags:
     commands:
       - launchApp:
           clearState: true
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
       - runFlow: steps/access_passwords_screen.yaml
 
       - assertVisible:

diff --git a/.maestro/autofill/3_autofill_prompted_to_save_creds_on_form.yaml b/.maestro/autofill/3_autofill_prompted_to_save_creds_on_form.yaml
@@ -9,7 +9,7 @@ tags:
       commands:
         - launchApp:
               clearState: true
-        - runFlow: ../shared/onboarding.yaml
+        - runFlow: ../shared/pre_onboarding.yaml
 
         - tapOn:
             id: "omnibarTextInput"

diff --git a/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml b/.maestro/autofill/backfillingUsername/multi_step_login_username_backfilled.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/...stro/autofill/backfillingUsername/multi_step_login_username_backfilled_for_an_update.yaml b/...stro/autofill/backfillingUsername/multi_step_login_username_backfilled_for_an_update.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # setup an existing credential
       - runFlow: ../steps/manually_add_existing_credential.yaml

diff --git a/.../backfillingUsername/multi_step_login_username_not_backfilled_if_provided_explicitly.yaml b/.../backfillingUsername/multi_step_login_username_not_backfilled_if_provided_explicitly.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/...ckfillingUsername/multi_step_registration_username_backfilled_password_autogenerated.yaml b/...ckfillingUsername/multi_step_registration_username_backfilled_password_autogenerated.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/...illingUsername/multi_step_registration_username_backfilled_password_manually_entered.yaml b/...illingUsername/multi_step_registration_username_backfilled_password_manually_entered.yaml
@@ -1,7 +1,7 @@
 appId: com.duckduckgo.mobile.android
 name: "Autofill: Will backfill username in a multi-step registration form with a manually entered password"
 tags:
-    - autofillBackfillingUsername
+    - x
 ---
 # Pre-requisite: Requires app be built with -Pautofill-disable-auth-requirement flag to disable auth requirement
 
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/.maestro/autofill/backfillingUsername/password_reset_flow_autogenerated_password.yaml b/.maestro/autofill/backfillingUsername/password_reset_flow_autogenerated_password.yaml
@@ -11,12 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
-      - runFlow: ../steps/decline_autofill_prompt.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill login form
       - tapOn:

diff --git a/...l/backfillingUsername/password_reset_flow_for_existing_credential_generated_password.yaml b/...l/backfillingUsername/password_reset_flow_for_existing_credential_generated_password.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill login form
       - tapOn:

diff --git a/...fill/backfillingUsername/password_reset_flow_for_existing_credential_manual_password.yaml b/...fill/backfillingUsername/password_reset_flow_for_existing_credential_manual_password.yaml
@@ -11,13 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
-
-      - runFlow: ../steps/manually_add_existing_credential.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill login form
       - tapOn:

diff --git a/...tofill/passwordGeneration/autosaves_credential_when_password_generated_with_username.yaml b/...tofill/passwordGeneration/autosaves_credential_when_password_generated_with_username.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/...ill/passwordGeneration/autosaves_credential_when_password_generated_without_username.yaml b/...ill/passwordGeneration/autosaves_credential_when_password_generated_without_username.yaml
@@ -11,11 +11,7 @@ tags:
       - launchApp:
           clearState: true
 
-      # optionally, run through onboarding if not already onboarded
-      - runFlow:
-          when:
-            visible: ".*Ready for a better, more private internet?.*"
-          file: ../../shared/onboarding.yaml
+      - runFlow: ../../shared/pre_onboarding.yaml
 
       # get to autofill form
       - tapOn:

diff --git a/.maestro/bookmarks/ensure_bookmarks_can_be_added_and_deleted.yaml b/.maestro/bookmarks/ensure_bookmarks_can_be_added_and_deleted.yaml
@@ -10,7 +10,7 @@ tags:
           clearState: true
           stopApp: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
           text: "search or type URL"

diff --git a/.maestro/bookmarks/open_bookmark_and_navigate_back.yaml b/.maestro/bookmarks/open_bookmark_and_navigate_back.yaml
@@ -10,7 +10,7 @@ tags:
             clearState: true
             stopApp: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
             text: "search or type URL"

diff --git a/.maestro/bookmarks/open_bookmark_in_folder_and_navigate_back.yaml b/.maestro/bookmarks/open_bookmark_in_folder_and_navigate_back.yaml
@@ -10,7 +10,7 @@ tags:
                   clearState: true
                   stopApp: true
 
-            - runFlow: ../shared/onboarding.yaml
+            - runFlow: ../shared/pre_onboarding.yaml
 
             - tapOn:
                   text: "search or type URL"

diff --git a/.maestro/browsing/visit_site.yaml b/.maestro/browsing/visit_site.yaml
@@ -10,7 +10,7 @@ tags:
           clearState: true
           stopApp: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
           text: "search or type URL"

diff --git a/.maestro/custom_tabs/custom_tabs_navigation.yaml b/.maestro/custom_tabs/custom_tabs_navigation.yaml
@@ -22,10 +22,11 @@ tags:
           commands:
             - tapOn: "duckduckgo"
             - tapOn: "set as default"
-            - assertVisible:
-                text: ".*Awesome! Welcome to the duck side.*"
-            - tapOn: "start browsing"
-
+      - assertVisible:
+          text: ".*where should I put your address bar?.*"
+      - tapOn: "next"
+      - assertVisible:
+          text: ".*Try a search!.*"
       - tapOn:
           id: "com.duckduckgo.mobile.android:id/browserMenuImageView"
       - tapOn:

diff --git a/.maestro/custom_tabs/custom_tabs_navigation_new_tab.yaml b/.maestro/custom_tabs/custom_tabs_navigation_new_tab.yaml
@@ -22,10 +22,11 @@ tags:
           commands:
             - tapOn: "duckduckgo"
             - tapOn: "set as default"
-            - assertVisible:
-                text: ".*Awesome! Welcome to the duck side.*"
-            - tapOn: "start browsing"
-
+      - assertVisible:
+          text: ".*where should I put your address bar?.*"
+      - tapOn: "next"
+      - assertVisible:
+          text: ".*Try a search!.*"
       - tapOn:
           id: "com.duckduckgo.mobile.android:id/browserMenuImageView"
       - tapOn:

diff --git a/.maestro/favorites/favorites_bookmarks_add.yaml b/.maestro/favorites/favorites_bookmarks_add.yaml
@@ -10,7 +10,7 @@ tags:
           clearState: true
           stopApp: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
           text: "search or type URL"

diff --git a/.maestro/favorites/favorites_bookmarks_delete.yaml b/.maestro/favorites/favorites_bookmarks_delete.yaml
@@ -10,7 +10,7 @@ tags:
           clearState: true
           stopApp: true
 
-      - runFlow: ../shared/onboarding.yaml
+      - runFlow: ../shared/pre_onboarding.yaml
 
       - tapOn:
           text: "search or type URL"