Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add named parameter support to virtual tables #250

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

Mause
Copy link
Member

@Mause Mause commented Jan 3, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9af377a) 60.33% compared to head (588e4d4) 60.62%.

Files Patch % Lines
src/vtab/function.rs 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   60.33%   60.62%   +0.29%     
==========================================
  Files          36       36              
  Lines        2115     2131      +16     
==========================================
+ Hits         1276     1292      +16     
  Misses        839      839              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mause Mause requested a review from wangfenjin January 15, 2024 08:32
@Mytherin Mytherin merged commit d48b967 into duckdb:main Feb 8, 2024
4 checks passed
@Mytherin
Copy link
Contributor

Mytherin commented Feb 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants