Explicitly pass NDEBUG down

duckdb · Sep 24, 2024 · 4d2b736 · 4d2b736
1 parent ab81737
commit 4d2b736
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/binding.gyp b/binding.gyp
@@ -384,7 +384,8 @@
                 "DUCKDB_EXTENSION_ICU_LINKED", 
                 "DUCKDB_EXTENSION_JSON_LINKED", 
                 "DUCKDB_EXTENSION_AUTOLOAD_DEFAULT=1", 
-                "DUCKDB_EXTENSION_AUTOINSTALL_DEFAULT=1"
+                "DUCKDB_EXTENSION_AUTOINSTALL_DEFAULT=1",
+                "NDEBUG"
             ], 
             "cflags_cc": [
                 "-frtti", 

diff --git a/vendor.py b/vendor.py
@@ -35,6 +35,7 @@
 
 # Autoloading is on by default for node distributions
 defines.extend(['DUCKDB_EXTENSION_AUTOLOAD_DEFAULT=1', 'DUCKDB_EXTENSION_AUTOINSTALL_DEFAULT=1'])
+defines.extend(['NDEBUG'])
 
 if os.environ.get('DUCKDB_NODE_BUILD_CACHE') == '1' and os.path.isfile(cache_file):
     with open(cache_file, 'rb') as f:
@@ -79,8 +80,6 @@ def find_library_path(libdir, libname):
             cflags += ['-g']
         if '-O0' in os.environ['DUCKDB_NODE_CFLAGS']:
             cflags += ['-O0']
-        if '-DNDEBUG' in os.environ['DUCKDB_NODE_CFLAGS']:
-            defines += ['NDEBUG']
 
     if 'DUCKDB_NODE_BUILD_CACHE' in os.environ:
         cache = {