Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stringify have to handle boxed values and Set/Map #320

Merged
merged 5 commits into from
Feb 26, 2019
Merged

Stringify have to handle boxed values and Set/Map #320

merged 5 commits into from
Feb 26, 2019

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Feb 25, 2019

Fixes #318
Fixes #319

@coveralls
Copy link

coveralls commented Feb 25, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 97.401% when pulling 8e97887 on feat/stringify into 0b7e94d on master.

@dubzzz
Copy link
Owner Author

dubzzz commented Feb 25, 2019

Maybe add some checks for cyclic objects, so that it does not loop infinitely (today it will crash if cyclic)

@dubzzz dubzzz merged commit 1b6ab39 into master Feb 26, 2019
@dubzzz dubzzz deleted the feat/stringify branch February 26, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubzzz @coveralls