Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump pure-rand for better performances #208

Merged
merged 1 commit into from
Oct 6, 2018
Merged

Bump pure-rand for better performances #208

merged 1 commit into from
Oct 6, 2018

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Oct 6, 2018

No description provided.

@dubzzz
Copy link
Owner Author

dubzzz commented Oct 6, 2018

Performance improvements related to issue #147

@dubzzz
Copy link
Owner Author

dubzzz commented Oct 6, 2018

pure-rand@1.4.1 replaces the usages of array destructuring by direct uses of [idx]. The performance improvement is important due to es3 transpilation that was adding lots of boilerplate to do the destructuration. Nonetheless it seems that even without transpilation, destructuring was more costly than direct accesses.

@dubzzz dubzzz merged commit 46428f9 into master Oct 6, 2018
@dubzzz dubzzz deleted the perf/bump-prand branch October 6, 2018 10:31
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.355% when pulling a941f49 on perf/bump-prand into 282ece5 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.355% when pulling a941f49 on perf/bump-prand into 282ece5 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.355% when pulling a941f49 on perf/bump-prand into 282ece5 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dubzzz @coveralls