Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify check for existing reference data in compare function #130

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

juraskov
Copy link
Member

@juraskov juraskov commented Feb 5, 2025

Fix issue #129

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.73%. Comparing base (3cb0ddb) to head (25d545a).

Files with missing lines Patch % Lines
mlptrain/configurations/configuration_set.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   64.75%   64.73%   -0.02%     
==========================================
  Files          37       37              
  Lines        4298     4299       +1     
==========================================
  Hits         2783     2783              
- Misses       1515     1516       +1     
Flag Coverage Δ
python-3.9 60.78% <0.00%> (-0.02%) ⬇️
python-3.9-ace 60.78% <0.00%> (-0.02%) ⬇️
python-3.9-mace 64.54% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juraskov juraskov requested a review from Hanwen1018 February 5, 2025 13:11
@juraskov juraskov merged commit c1a9e9e into duartegroup:main Feb 5, 2025
4 checks passed
@juraskov juraskov deleted the compare_fix branch February 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error encountered when call .compare function when the true energy and force files are empty
3 participants