Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use topViewController not rootViewController #47

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Use topViewController not rootViewController #47

merged 4 commits into from
Apr 8, 2020

Conversation

naoyanickf
Copy link
Contributor

I changed topViewController function of DialogManager.swift.

My fix use topViewController not rootViewController when topViewController is available.

In my case,

  • When launching app, I check whether user is already logged in or not.
  • If logged in, I present mainViewController quickly.
  • Update alert didn't show up because of "whose view is not in the window hierarchy!" error.

So,
I'm using the most top topViewController when it's available.

Swift 4.2
Xcode 10.2.1

houndci-bot
houndci-bot reviewed Jun 28, 2019
View reviewed changes
dtrenz
dtrenz approved these changes Apr 8, 2020
View reviewed changes
Copy link
Owner

@dtrenz dtrenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

@dtrenz dtrenz merged commit 623d664 into dtrenz:develop Apr 8, 2020
@dtrenz
Copy link
Owner

dtrenz commented Apr 8, 2020

Released in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@dtrenz dtrenz dtrenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@naoyanickf @dtrenz @houndci-bot