Use a flat layout for TokenBuffer #1223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a small perf win:
Replaces #1196. With a flat tokenbuffer, implementing
Ord
forCursor
will become trivial.I did try a bit to make
Cursor
store&[Entry]
directly, but I was having trouble doing so as part of this change. It might still be a worthwhile followup to reduce the necessary amount ofunsafe
, but doesn't need to be done immediately.The biggest code quality question is probably how I handled changing
bump
.