-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special case quote!
/quote_spanned!
for 1 and 2 tts.
#217
Conversation
Some instruction counts results for non-incremental
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks promising.
The failing ui test should be fixed if you rebase past 31c3be4. Rustc's diagnostics sometimes change.
Edit: nope, that isn't it. This PR is causing the diagnostic change. You can run TRYBUILD=overwrite cargo +nightly test --test compiletest
to update the test case.
42fa703
to
9a2530a
Compare
CI gets one test error, but I get two locally -- the second one in |
These make crates that use `quote` compile faster. I also tried specializing for 3 tts, but the rules are more complex and the additional perf wins are much smaller than they are for 1 and 2 tts.
9a2530a
to
4d75f2e
Compare
Whoops, no, I pushed a version with both test changes. This time it should just be the one change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
These make crates that use
quote
compile faster.I also tried specializing for 3 tts, but the rules are more complex and
the additional perf wins are much smaller than they are for 1 and 2 tts.