Avoid panic when using quote! on raw identifiers #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `quote!` optimization added in 8d155b0 calls `Ident::new`, which does not handle identifiers containing the `r#` raw prefix, panicing if they are passed in. As `Ident::new_raw` is not stable, raw identifiers are parsed using the existing `parse` codepath, with only non-raw identifiers being passed to `Ident::new`. This mimics the logic from the `mk_ident` method created for `format_ident!`, with some small optimizations due to relaxed requirements. The previous `is_ident` optimization within `__rt::parse` has also been removed, as it is now redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
quote!optimization added in 8d155b0 callsIdent::new, which does not handle identifiers containing ther#raw prefix, panicing if they are passed in.As
Ident::new_rawis not stable, raw identifiers are parsed using the existingparsecodepath, with only non-raw identifiers being passed toIdent::new. This mimics the logic from themk_identmethod created forformat_ident!, with some small optimizations due to relaxed requirements.The previous
is_identoptimization within__rt::parsehas also been removed, as it is now redundant.