Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacebattles award links #1335

Closed
nakie08 opened this issue Jun 3, 2024 · 3 comments
Closed

Spacebattles award links #1335

nakie08 opened this issue Jun 3, 2024 · 3 comments

Comments

@nakie08
Copy link

nakie08 commented Jun 3, 2024

Describe the bug
Spacebattles award links on threadmarks are getting picked up as chapter URLs

To Reproduce
Steps to reproduce the behavior:

  1. Go to a fiction on Spacebattles with atleast 1 award. This one https://forums.spacebattles.com/threads/a-greater-game-b5-btech.1140373/ for example has an award on the first chapter and several awards on chapter 20 and onwards.
  2. Click on WebToEpub plugin
  3. Check to see the extra "chapters" which are the ribbon URLs. On the link I provided it would have 2 chapter 1s and a chapter "1" after chapter 23.
  4. Try to pack epub only to fail at extra chapters since it can't parse them.

Expected behavior
The plugin disregards the ribbon award links on threadmarks

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version [e.g. 22]

Additional context
You can just manually deselect the extra chapters ofcourse but it may get tedious on fictions with large number of chapters and awards. Also I'm not sure what award gets picked up. For example on the link I provided the awards on chapter 1 and 23 are getting picked up while the rest aren't.

@dteviot
Copy link
Owner

dteviot commented Jun 4, 2024

@nakie08

Test versions for Firefox and Chrome have been uploaded to https://drive.google.com/drive/folders/1B_X2WcsaI_eg9yA-5bHJb8VeTZGKExl8?usp=sharing. Pick the one suitable for you, follow the "How to install from Source (for people who are not developers)" instructions at https://github.com/dteviot/WebToEpub/tree/ExperimentalTabMode#user-content-how-to-install-from-source-for-people-who-are-not-developers and let me know how it goes.
Tested with:

For my notes: 12 minutes work

dteviot added a commit that referenced this issue Jun 4, 2024
Fix: Spacebattles award links on threadmarks are picked up
as chapter URLs.

See: #1335
@nakie08
Copy link
Author

nakie08 commented Jun 4, 2024

Tested it with several other fics. Seems like it's fixed now. Thank you!

@dteviot
Copy link
Owner

dteviot commented Jun 16, 2024

@nakie08

Updated version (0.0.0.160) has been submitted to Firefox and Chrome stores.
Firefox version is available now.
Chrome might be available in a few hours to 21 days.

@dteviot dteviot closed this as completed Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants