Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect present_mode when creating the Pixels instance #20

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

tryone144
Copy link
Contributor

Bevy's WindowPlugin allows passing a present_mode flag to control wgpu's presentation or flip mode for the display surface. This is originally read and applied in the internals of bevy's own renderer.

We should respect this flag and apply it when creating the Pixels instance (which does the wgpu handling internally). This is achieved by using the PixelsBuilder instead of the Pixels::new() function and setting the requested present_mode with the PixelsBuilder::present_mode() function.


Ideally, we would detect changes to this field as well and then request pixels to update the present_mode. This is currently not possible with version 0.13, but parasyte/pixels#373 added a new setter on the Pixels instance that would allow exactly this. I expect this to land in the next release of pixels.

@dtcristo
Copy link
Owner

dtcristo commented Dec 7, 2023

Very nice. I'll have a play with this and merge it soon.

@dtcristo dtcristo merged commit 0d6218d into dtcristo:main Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants