Respect present_mode when creating the Pixels instance #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bevy's WindowPlugin allows passing a
present_mode
flag to control wgpu's presentation or flip mode for the display surface. This is originally read and applied in the internals of bevy's own renderer.We should respect this flag and apply it when creating the
Pixels
instance (which does the wgpu handling internally). This is achieved by using thePixelsBuilder
instead of thePixels::new()
function and setting the requestedpresent_mode
with thePixelsBuilder::present_mode()
function.Ideally, we would detect changes to this field as well and then request pixels to update the present_mode. This is currently not possible with version
0.13
, but parasyte/pixels#373 added a new setter on thePixels
instance that would allow exactly this. I expect this to land in the next release of pixels.