Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stark-core): complementary fixes for feature/bootstrap #5

Merged

Conversation

christophercr
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Travis CI build failing due to module "@angularclass/hmr" not found.

What is the new behavior?

Travis CI build successful.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

chore(stark-all): remove "testing" subpackages from greenkeeper config file since they have no dependencies
@christophercr
Copy link
Author

@dsebastien I've fixed the issues you had in your PR (except the greenkeeper file which is already in stark but you need to rebase). So you can merge this in your branch and update your PR to Stark master ;)

@dsebastien dsebastien merged commit ba9fc2b into dsebastien:feature/bootstrap Jul 5, 2018
@christophercr christophercr deleted the feature/bootstrap branch July 6, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants