Updated test class to use correct disposable pattern

dscpinheiro · Dec 5, 2019 · e5f3ee9 · e5f3ee9
1 parent ebb4048
commit e5f3ee9
Showing 1 changed file with 26 additions and 1 deletion.
diff --git a/Messages.Tests/Validation/ValidationTests.cs b/Messages.Tests/Validation/ValidationTests.cs
@@ -13,14 +13,18 @@ namespace Messages.Tests.Validation
     public class ValidationTests : IClassFixture<WebApplicationFactory<Startup>>, IDisposable
     {
         private readonly WebApplicationFactory<Startup> _factory;
+        private bool _isDisposed;
 
         public ValidationTests(WebApplicationFactory<Startup> factory)
         {
             _factory = factory;
             Environment.SetEnvironmentVariable("ASPNETCORE_ENVIRONMENT", "CI");
         }
 
-        public void Dispose() => Environment.SetEnvironmentVariable("ASPNETCORE_ENVIRONMENT", null);
+        ~ValidationTests()
+        {
+            Dispose(false);
+        }
 
         [Theory, ClassData(typeof(InvalidWriteRequestData))]
         public async Task Validation_InvalidRequest_ReturnsBadRequest(string message)
@@ -43,5 +47,26 @@ public async Task Validation_ValidRequest_ReturnsCreated(string message)
             Assert.True(response.IsSuccessStatusCode);
             Assert.Equal(HttpStatusCode.Created, response.StatusCode);
         }
+
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        protected virtual void Dispose(bool isDisposing)
+        {
+            if (_isDisposed)
+            {
+                return;
+            }
+
+            if (isDisposing)
+            {
+                Environment.SetEnvironmentVariable("ASPNETCORE_ENVIRONMENT", null);
+            }
+
+            _isDisposed = true;
+        }
     }
 }