Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter Plugin Upgrade and Build Error solved #218

Merged
merged 3 commits into from
Nov 11, 2021

Conversation

nayakastha
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Description

  • Migrated to AndroidX to keep all the plugins updated
  • Changed the Kotlin version for the application to make sure it works for all the latest plugins
  • Changed the flutter_webview_plugin to webview_flutter since the former isn't a maintained plugin

❤️Thank you!

@github-actions
Copy link

image image
Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@github-actions
Copy link

image image
Hello @nayakastha , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@nayakastha nayakastha linked an issue Nov 11, 2021 that may be closed by this pull request
Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

scp/lib/chat.dart Show resolved Hide resolved
@dsc-nitr dsc-nitr merged commit f15f731 into dscnitrourkela:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the deprecated version of the Android embedding.
4 participants