Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored homePage in MVVM architecture #196

Merged
merged 1 commit into from
Jan 12, 2021
Merged

refactored homePage in MVVM architecture #196

merged 1 commit into from
Jan 12, 2021

Conversation

haru-02
Copy link
Contributor

@haru-02 haru-02 commented Jan 5, 2021

added homePage folder under which there is a view and viewmodel file. also modified routes file accordingly and fixed small errors on scp/lib/services/localStorage_service.dart.

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Description

Please describe your pull request.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

added homePage folder under which there is a view and viewmodel file. also modified routes file accordingly and fixed small errors on scp/lib/services/localStorage_service.dart.
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

image image
Hello @haru-02 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@Thesmader Thesmader requested a review from Chinmay-KB January 12, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants