Add flag to include dev dependencies #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergo-papp
reviewed
May 26, 2021
|
|
||
| - run: mix kudos.generate --dry-run | ||
|
|
||
| - run: mix kudos.generate --include-dev-deps |
There was a problem hiding this comment.
This could be a future improvement: What do you think about committing the licensed.md file and asserting that it matches to what this command generates.
Submitting the license file is also a nice way to show visitors an example of the generated file
There was a problem hiding this comment.
Like the idea of committing the licenses.md unfortunately for non dev it would be empty.
Or what about a checker wich can be called in the pipeline, like mix kudos.compliant or mix kudos.complete. Will merge this for now. We can think about adding this in the next release.
Co-authored-by: Gergő Papp-Szentannai <gergo.papp-szentannai@ni.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed earlier and will close #11 this PR add a flag for including development dependencies in the generation process.