Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xVMSwitch - Get-TargetResource throws when switch type is not external #107

Closed
bgelens opened this issue Jun 30, 2017 · 0 comments
Closed

xVMSwitch - Get-TargetResource throws when switch type is not external #107

bgelens opened this issue Jun 30, 2017 · 0 comments
Assignees
@bgelens
Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub

Comments

@bgelens
Copy link
Contributor

bgelens commented Jun 30, 2017 •
edited
Loading

Bug introduced by PR #96.
Get-TargetResource doesn't take into account that it shouldn't query for NetAdapterInterfaceDescription(s) when switch type is Private or Internal
@bgelens bgelens added bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub labels Jun 30, 2017
@bgelens bgelens self-assigned this Jun 30, 2017
@bgelens bgelens mentioned this issue Jun 30, 2017
Merged
bgelens added a commit that referenced this issue Jul 1, 2017
@bgelens
Merge pull request #109 from bgelens/bgelens
fbca5c0 
xVMSwitch - Fixes #107 and fixes #108 adds comment based help and updates unit tests to latest template version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgelens bgelens

Labels
bug The issue is a bug. good first issue The issue should be easier to fix and can be taken up by a beginner to learn to contribute on GitHub
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bgelens