Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result based caching #586

Merged
merged 4 commits into from
Apr 26, 2018
Merged

Result based caching #586

merged 4 commits into from
Apr 26, 2018

Conversation

pmelab
Copy link
Contributor

@pmelab pmelab commented Apr 26, 2018

Revert the cache context detection back to pulling them from the results directly.

See #584

@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #586 into 8.x-3.x will decrease coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           8.x-3.x     #586      +/-   ##
===========================================
- Coverage    80.73%   80.37%   -0.37%     
===========================================
  Files          186      185       -1     
  Lines         2860     2843      -17     
===========================================
- Hits          2309     2285      -24     
- Misses         551      558       +7
Impacted Files Coverage Δ
src/GraphQL/Execution/QueryProcessor.php 91.32% <100%> (-0.1%) ⬇️
.../Plugin/GraphQL/Interfaces/InterfacePluginBase.php 75% <0%> (-21.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e44f86a...e3859d5. Read the comment docs.

@fubhy fubhy merged commit 8ae1c4b into 8.x-3.x Apr 26, 2018
@fubhy fubhy deleted the result-based-caching branch April 28, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants