feat(utility/fileupload): file_validate_image_resolution

[aurelianzaha]

make it possible to validate the image resolution

file size and file extension validation is already in place

[klausi]

Makes sense, can simplify a bit with the ?? operator?

[klausi]

Hm, but will this change be enough? getUploadValidators() is called only once, then the $validator array is passed to prepareFilename(), but it is never looped over?

Can you add a test case to UploadFileServiceTest?

We copied the code from Drupal core FileItem, how does an image file item handle this? I guess it is done in ImageWidget, that's why it is missing.

[klausi]

Another problem is that you cannot use file_validate_image_resolution() fully because it invokes the drupal message system when changing the scale of an image. That is not ideal, as it starts a user session that you don't need.

So probably you will need a copy of file_validate_image_resolution() as method in our file upload service.

[aurelianzaha]

Hm, but will this change be enough? getUploadValidators() is called only once, then the $validator array is passed to prepareFilename(), but it is never looped over?

Can you add a test case to UploadFileServiceTest?

We copied the code from Drupal core FileItem, how does an image file item handle this? I guess it is done in ImageWidget, that's why it is missing.

@klausi yes, that is enough, the $validators array is used here
https://github.com/drupal-graphql/graphql/blob/8.x-4.x/src/GraphQL/Utility/FileUpload.php#L261
this is where the loop happens

[aurelianzaha]

@klausi I made a copy of file_validate_image_resolution do we still need the tests ?

[klausi]

Ah great, overlooked file_validate().

Yes, please add a test!

[klausi]

Thanks, approach makes sense. I see some minor issues and please add a test case for minimum resolution settings as well that you get out an error message.

[klausi]

Looks good, thanks!