feat(SdlSchemaPluginBase): Allow altering of schemas by introducing alter events (#1301) #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to receive a review about the approach and then continue with tests for it. |
|
Thanks, makes sense to me. We have 2 events with this approach, I think that is ok to separate schema and extensions and be able to alter them separately. I think you can go ahead now and provide some test coverage once this is sufficient for our use case. |
…dlSchemaPluginBase.php updates.
2b0e918 to
230e4b2
Compare
29baf9e to
92674e9
Compare
klausi
requested changes
Oct 4, 2022
tests/modules/graphql_alterable_schema_test/src/EventSubscriber/GraphQlSubscriber.php
Outdated
Show resolved
Hide resolved
klausi
approved these changes
Oct 5, 2022
|
Thank you! |
|
Thanks for sticking with us and incorporating all the feedback @akhomy ! |
|
My pleasure. And thank you for the excellent discussion about the right approach. |
klausi
pushed a commit
to klausi/graphql
that referenced
this pull request
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from the issue - #1301