Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HealthCheckServlet object mapper and status indicator #1871

Merged
merged 4 commits into from
Apr 18, 2021

Conversation

joschi
Copy link
Member

@joschi joschi commented Apr 15, 2021

  • Allow overriding the ObjectMapper instance used in HealthCheckServlet with the servlet attribute com.codahale.metrics.servlets.HealthCheckServlet.mapper
  • Allow setting the HTTP status code used to indicate health to 200 (OK) with the servlet attribute com.codahale.metrics.servlets.HealthCheckServlet.httpStatusIndicator, or with the HTTP query parameter httpStatusIndicator per request

Refs #1821

- Allow overriding the `ObjectMapper` instance used in `HealthCheckServlet` with the servlet attribute `com.codahale.metrics.servlets.HealthCheckServlet.mapper`
- Allow setting the HTTP status code used to indicate health to 200 (OK) with the servlet attribute `com.codahale.metrics.servlets.HealthCheckServlet.httpStatusIndicator`, or with the HTTP query parameter `httpStatusIndicator` per request

Refs #1821
@joschi joschi added this to the 4.1.20 milestone Apr 15, 2021
@joschi joschi self-assigned this Apr 15, 2021
@joschi joschi marked this pull request as ready for review April 15, 2021 12:26
@joschi joschi requested review from a team as code owners April 15, 2021 12:26
@sonarqubecloud
Copy link

@joschi joschi merged commit 1036033 into release/4.1.x Apr 18, 2021
@joschi joschi deleted the pr-1821-http-status-code branch April 18, 2021 13:52
joschi added a commit that referenced this pull request Jan 24, 2024
- Allow overriding the `ObjectMapper` instance used in `HealthCheckServlet` with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.mapper`
- Allow setting the HTTP status code used to indicate health to 200 (OK) with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.httpStatusIndicator`, or with the HTTP query parameter `httpStatusIndicator` per request

Refs #1821
Refs #1871
joschi added a commit that referenced this pull request Jan 24, 2024
- Allow overriding the `ObjectMapper` instance used in `HealthCheckServlet` with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.mapper`
- Allow setting the HTTP status code used to indicate health to 200 (OK) with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.httpStatusIndicator`, or with the HTTP query parameter `httpStatusIndicator` per request

Refs #1821
Refs #1871
joschi added a commit that referenced this pull request Jan 24, 2024
- Allow overriding the `ObjectMapper` instance used in `HealthCheckServlet` with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.mapper`
- Allow setting the HTTP status code used to indicate health to 200 (OK) with the servlet attribute `io.dropwizard.metrics.servlets.HealthCheckServlet.httpStatusIndicator`, or with the HTTP query parameter `httpStatusIndicator` per request

Refs #1821
Refs #1871
Fixes #3918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant