-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument ThreadPoolExecutor and ForkJoinPool #1535
Comments
@pkwarren I think this makes sense and would be a nice addition. 👍 Would you be able to provide a PR for this for Dropwizard Metrics 4.2.x? |
Yep - I've been meaning to raise a PR to add this. Hope to get to it shortly. |
@pkwarren Did you get any chance to start working on this? |
@joschi - No I haven't. I'm not currently using DW at work and haven't had as much time as before for OSS work. |
joschi
added a commit
that referenced
this issue
May 10, 2021
joschi
added a commit
that referenced
this issue
May 10, 2021
joschi
added a commit
that referenced
this issue
May 10, 2021
joschi
added a commit
that referenced
this issue
May 10, 2021
joschi
added a commit
that referenced
this issue
May 10, 2021
Closed via #1928 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current instrumentation for ExecutorService doesn't expose several useful properties of subclasses which can be helpful when determining how to properly size an executor. The current instrumentation exposes the following:
Micrometer exposes quite a few additional properties of both ThreadPoolExecutor and ForkJoinPool: https://micrometer.io/docs/ref/jvm. It would be helpful to expose these in addition to the current metrics (in particular, the gauges for the number of threads, size of queued tasks, etc.)
The text was updated successfully, but these errors were encountered: