Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument ThreadPoolExecutor and ForkJoinPool #1535

Closed
pkwarren opened this issue Jan 29, 2020 · 5 comments · Fixed by #1928
Closed

Instrument ThreadPoolExecutor and ForkJoinPool #1535

pkwarren opened this issue Jan 29, 2020 · 5 comments · Fixed by #1928
Assignees
Milestone

Comments

@pkwarren
Copy link

The current instrumentation for ExecutorService doesn't expose several useful properties of subclasses which can be helpful when determining how to properly size an executor. The current instrumentation exposes the following:

  • Meter: submitted, completed
  • Counter: running
  • Timer: idle, duration

Micrometer exposes quite a few additional properties of both ThreadPoolExecutor and ForkJoinPool: https://micrometer.io/docs/ref/jvm. It would be helpful to expose these in addition to the current metrics (in particular, the gauges for the number of threads, size of queued tasks, etc.)

@joschi
Copy link
Member

joschi commented May 13, 2020

@pkwarren I think this makes sense and would be a nice addition. 👍

Would you be able to provide a PR for this for Dropwizard Metrics 4.2.x?

@joschi joschi added this to the 4.2.0 milestone May 13, 2020
@pkwarren
Copy link
Author

Yep - I've been meaning to raise a PR to add this. Hope to get to it shortly.

@github-actions github-actions bot added the Stale label Nov 10, 2020
@joschi joschi removed the Stale label Jan 10, 2021
@dropwizard dropwizard deleted a comment from github-actions bot Jan 10, 2021
@joschi joschi reopened this Jan 10, 2021
@joschi
Copy link
Member

joschi commented Mar 15, 2021

@pkwarren Did you get any chance to start working on this?

@pkwarren
Copy link
Author

@joschi - No I haven't. I'm not currently using DW at work and haven't had as much time as before for OSS work.

@joschi
Copy link
Member

joschi commented May 11, 2021

Closed via #1928

@joschi joschi closed this as completed May 11, 2021
@joschi joschi linked a pull request May 11, 2021 that will close this issue
joschi added a commit that referenced this issue May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants