Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make better use of AssertJ AtomicAssert and FutureAssert #4661

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Make better use of AssertJ AtomicAssert and FutureAssert #4661

merged 1 commit into from
Jan 28, 2022

Conversation

rhowe
Copy link
Contributor

@rhowe rhowe commented Jan 28, 2022

AssertJ supports asserting on Atomic* types directly - no need to call .get().

Also, make use of FutureAssert when asserting on Futures.

@rhowe rhowe requested a review from a team as a code owner January 28, 2022 09:00
@rhowe
Make better use of AssertJ AtomicAssert and FutureAssert
e8fa8f2 
AssertJ supports asserting on Atomic* types directly - no need to call
`.get()`.

Also, make use of `FutureAssert` when asserting on `Future`s.
@rhowe rhowe force-pushed the more-assert-improvements branch from d762d10 to e8fa8f2 Compare January 28, 2022 09:02
@joschi joschi added this to the 2.1.0 milestone Jan 28, 2022
@joschi joschi merged commit 4c2560b into dropwizard:master Jan 28, 2022
@rhowe rhowe deleted the more-assert-improvements branch January 28, 2022 20:32
@renovate renovate bot mentioned this pull request Jul 16, 2022
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joschi joschi joschi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhowe @joschi