DROOP-1043 Divider is not visible when there is no header and content #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-droptica
reviewed
Jan 4, 2024
| {% block header %} | ||
| {% endblock %} | ||
|
|
||
| {% if has_content %} |
There was a problem hiding this comment.
Is this condition needed? Is there a possibility of having a header without content in this component?
There was a problem hiding this comment.
Yes, because these fields are not set as required.
js-droptica
reviewed
Jan 4, 2024
| {% block content %} | ||
| {% endblock %} | ||
| </div> | ||
| {% if has_header or has_content %} |
There was a problem hiding this comment.
Is this condition needed? Is there a possibility of not having both blocks?
There was a problem hiding this comment.
Yes, there is such possibility. In this case, there's a big empty space next to the form, which looks strange. If this condition is not met, the empty space will not be rendered and the form will be centered.
There was a problem hiding this comment.
I see, content - header content, not form ;) Get it
js-droptica
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.