Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/droop 1024 cta title required #859

Merged
merged 2 commits into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
'#default_value' => $options['type'] ?? ButtonTypeEnum::Primary->value,
];

$parent_elements = parent::formElement($items, $delta, $element, $form, $form_state);
$parent_elements['title']['#required'] = TRUE;

return $element + $parent_elements;
return $element + parent::formElement($items, $delta, $element, $form, $form_state);
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ translatable: true
default_value: { }
default_value_callback: ''
settings:
title: 2
link_type: 17
title: 1
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ translatable: true
default_value: { }
default_value_callback: ''
settings:
title: 1
title: 2
link_type: 17
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ translatable: true
default_value: { }
default_value_callback: ''
settings:
title: 1
title: 2
link_type: 17
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ default_value: { }
default_value_callback: ''
settings:
link_type: 17
title: 1
title: 2
field_type: link
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ dependencies:
module:
- d_p
- field_group
- link_attributes
- media_library
- text
third_party_settings:
Expand Down Expand Up @@ -84,21 +83,22 @@ bundle: d_p_tiles
mode: default
content:
field_d_cta_link:
type: link_attributes
type: button_link_widget
weight: 5
region: content
settings:
placeholder_url: ''
placeholder_title: ''
enabled_attributes:
id: true
name: true
target: true
rel: true
class: true
accesskey: true
aria-label: false
title: false
id: id
name: name
target: target
rel: rel
class: class
accesskey: 0
aria-label: 0
title: 0
widget_default_open: expandIfValuesSet
third_party_settings: { }
field_d_long_text:
type: text_textarea
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ dependencies:
- field.field.paragraph.d_p_tiles.field_d_settings
- paragraphs.paragraphs_type.d_p_tiles
module:
- d_p
- field_group
- link
- text
third_party_settings:
field_group:
Expand Down Expand Up @@ -96,14 +96,14 @@ bundle: d_p_tiles
mode: default
content:
field_d_cta_link:
type: link
type: button_link_formatter
label: hidden
settings:
trim_length: 80
trim_length: '80'
url_only: false
url_plain: false
rel: ''
target: ''
rel: 0
target: 0
third_party_settings: { }
weight: 5
region: content
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ dependencies:
- media
id: media.d_tiles_gallery_fullscreen
label: 'Tiles gallery fullscreen'
description: ''
targetEntityType: media
cache: true
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ dependencies:
- media
id: media.tiles_gallery_fullscreen_featured
label: 'Tiles gallery fullscreen featured'
description: ''
targetEntityType: media
cache: true
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ translatable: true
default_value: { }
default_value_callback: ''
settings:
title: 2
link_type: 17
title: 1
field_type: link