Merge pull request #852 from droptica/feature/DROOP-1026-Error-displa…

…yed-when-background-video-is-added-to-Banner-Paragraph DROOP-1026: Fixed wrong type declarations in ProviderManager
droptica · Dec 21, 2023 · 9949aa1 · 9949aa1
2 parents 4f9c189 + 8dc8add
commit 9949aa1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/modules/custom/d_media/src/Service/ProviderManager.php b/modules/custom/d_media/src/Service/ProviderManager.php
@@ -27,7 +27,7 @@ public function __construct(\Traversable $namespaces, CacheBackendInterface $cac
   /**
    * {@inheritdoc}
    */
-  public function filterApplicableDefinitions(array $definitions, $user_input): ProviderPluginInterface|false {
+  public function filterApplicableDefinitions(array $definitions, $user_input): array|false {
     foreach ($definitions as $definition) {
       $is_applicable = $definition['class']::isApplicable($user_input);
       if ($is_applicable) {
@@ -49,7 +49,7 @@ public function loadProviderFromInput($input): ProviderPluginInterface|false {
   /**
    * {@inheritdoc}
    */
-  public function loadDefinitionFromInput($input): ProviderPluginInterface|false {
+  public function loadDefinitionFromInput($input): array|false {
     return $this->filterApplicableDefinitions($this->getDefinitions(), $input);
   }
 

diff --git a/modules/custom/d_media/src/Service/ProviderManagerInterface.php b/modules/custom/d_media/src/Service/ProviderManagerInterface.php
@@ -12,17 +12,17 @@
 interface ProviderManagerInterface {
 
   /**
-   * Get the provider applicable to the given user input.
+   * Get the provider definition applicable to the given user input.
    *
    * @param array $definitions
    *   A list of definitions to test against.
    * @param string $user_input
    *   The user input to test against the plugins.
    *
-   * @return \Drupal\d_media\Plugin\Provider\ProviderPluginInterface|false
-   *   The relevant plugin or FALSE on failure.
+   * @return array|false
+   *   The relevant provider definition or FALSE on failure.
    */
-  public function filterApplicableDefinitions(array $definitions, $user_input): ProviderPluginInterface|false;
+  public function filterApplicableDefinitions(array $definitions, $user_input): array|false;
 
   /**
    * Load a provider from user input.
@@ -41,9 +41,9 @@ public function loadProviderFromInput($input): ProviderPluginInterface|false;
    * @param string $input
    *   An input string.
    *
-   * @return \Drupal\d_media\Plugin\Provider\ProviderPluginInterface|false
+   * @return array|false
    *   The relevant plugin or FALSE on failure.
    */
-  public function loadDefinitionFromInput($input): ProviderPluginInterface|false;
+  public function loadDefinitionFromInput($input): array|false;
 
 }