Simplify mem cell alloc usage #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce several helper memory allocation functions to reduce boilerplate code. This will help in the future to further simplify allocation, esp when alloc module becomes part of stdlib. The helper functions allow far simpler usage with a generic type as the first param. I began with this replacement: ``` \<([a-zA-Z0-9_]+) as Allocator\<([a-zA-Z0-9_]+)\>\>\:\:AllocatedMemory\:\:default\(\s*\) ``` with ``` alloc_default::<$2, $1>() ``` In a few cases, I was able to use `alloc.alloc_cell(...)` directly (compiler was able to figure out which type to use automatically). Afterward, found all conditional allocations and replaced them with `alloc_if(condition, ...)`, and fixed the imports
Open
|
@danielrh when you have a chance, please merge this one early on because it might conflict with some other PRs. It should be fairly straight to review, as most changes were search/replaced |
danielrh
approved these changes
May 19, 2024
| }, | ||
| // FIXME: makes little sense to test if N+2 > 0 -- always true unless wrapping. Perhaps use allocate() instead? | ||
| literal_costs_: alloc_or_default::<floatX, _>(m, num_bytes + 2), | ||
| // FIXME: possible bug because allocation size is different from the condition |
There was a problem hiding this comment.
This does seem to be a bug per https://chromium.googlesource.com/chromium/src/third_party/+/refs/heads/main/brotli/enc/backward_references_hq.c#109
but lets fix it in a subsequent PR and test it carefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce several helper memory allocation functions to reduce boilerplate code. This will help in the future to further simplify allocation, esp when alloc module becomes part of stdlib. The helper functions allow far simpler usage with a generic type as the first param.
I began with this replacement:
with
In a few cases, I was able to use
alloc.alloc_cell(...)directly (compiler was able to figure out which type to use automatically).Afterward, found all conditional allocations and replaced them with
alloc_if(condition, ...), and fixed the imports