Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move menu to horizontal #201

Closed
wants to merge 3 commits into from
Closed

move menu to horizontal #201

wants to merge 3 commits into from

Conversation

kwolfy
Copy link

@kwolfy kwolfy commented Apr 7, 2018

I suggest moving the menu to a horizontal area to improve usability. It's actually resolve #187 too.
Screenshots:
img2
img1

Copy link

@tboerger tboerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could add also a Screenshot of a different page, not only about builds?

undefined
) : (
<section>
{build.status === "peding" ||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Should be pending.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but it was in the master
https://github.com/drone/drone-ui/blob/master/src/screens/repo/screens/build/menu.js#L69

In any case I fixed in last commit

@kwolfy
Copy link
Author

kwolfy commented Apr 8, 2018

@tboerger There is just one more screen with menu right now
img4

@tboerger
Copy link

tboerger commented Apr 8, 2018

Is there anything left on the burger menu?

@kwolfy
Copy link
Author

kwolfy commented Apr 8, 2018

@tboerger Yes, there are repositories, token, logout
img5

@laszlocph
Copy link

I'm using this in my fork for 2 weeks now. Quality stuff.

Please consider merging it.

@gtaylor
Copy link

gtaylor commented May 16, 2018

This has tripped up our new users, in particular.

@KGHustad
Copy link

This change causes the menu to be visible for non-authenticated users viewing public repos, but it doesn't make sense for them to see anything but the "Builds" (and maybe "Settings") in the menu. The "Secrets" and "Registry" tabs both show "Loading" indefinitely, while "Settings" is viewable.

Screenshot:
screen shot 2018-05-20 at 17 04 55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the restart build button out of the hamburger menu
6 participants