-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move menu to horizontal #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you could add also a Screenshot of a different page, not only about builds?
undefined | ||
) : ( | ||
<section> | ||
{build.status === "peding" || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo? Should be pending.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so, but it was in the master
https://github.com/drone/drone-ui/blob/master/src/screens/repo/screens/build/menu.js#L69
In any case I fixed in last commit
@tboerger There is just one more screen with menu right now |
Is there anything left on the burger menu? |
@tboerger Yes, there are repositories, token, logout |
I'm using this in my fork for 2 weeks now. Quality stuff. Please consider merging it. |
This has tripped up our new users, in particular. |
This change causes the menu to be visible for non-authenticated users viewing public repos, but it doesn't make sense for them to see anything but the "Builds" (and maybe "Settings") in the menu. The "Secrets" and "Registry" tabs both show "Loading" indefinitely, while "Settings" is viewable. |
I suggest moving the menu to a horizontal area to improve usability. It's actually resolve #187 too.


Screenshots: