[후원사] 2024 후원사 데이터 반영 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results18 tests 18 ✅ 5s ⏱️ Results for commit 77e20c5. ♻️ This comment has been updated with latest results. |
KimReady
commented
Apr 22, 2024
Comment on lines
+93
to
+107
| sponsors | ||
| .groupBy { it.grade } | ||
| .toSortedMap(compareBy { it.priority }) | ||
| .values | ||
| .forEachIndexed { index, groupedSponsorsByGrade -> | ||
| SponsorGroupRow( | ||
| modifier = Modifier | ||
| .wrapContentWidth() | ||
| .padding( | ||
| start = if (index % 2 == 0) 0.dp else 36.dp, | ||
| end = if (index % 2 == 0) 36.dp else 0.dp, | ||
| ), | ||
| sponsors = groupedSponsorsByGrade | ||
| ) | ||
| } |
There was a problem hiding this comment.
UI 에서는 후원사 등급을 몰라도 되도록 수정했어요.
taehwandev
reviewed
Apr 23, 2024
| .groupBy { it.grade } | ||
| .toSortedMap(compareBy { it.priority }) | ||
| .values | ||
| .forEachIndexed { index, groupedSponsorsByGrade -> |
There was a problem hiding this comment.
이렇게하면 리컴포지션 탈때마다 새로운 리스트를 다시 계산하게됩니다.
ViewModel에서 처리하도록 변경해주세요.
View에는 최종 데이터만 있으면 됩니다.
|
머지합니다. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)