Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Swift 6 support and switch to swift-testing #283

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

drmohundro
Copy link
Owner

@drmohundro drmohundro commented Aug 16, 2024

At least relates to #281.

The bulk of this work is actually switching to swift-testing.

Questions to consider (this list may grow):

  • What is the best approach for getting Swift 6 in the build? Still using swiftenv or is there a better approach now?
    • I can just use a matrix build and specify the image that has Swift 6 in it... pretty easy.
    • Though I'm unsure about the MacOS side yet... probably just need to wait for it to release
      • I was able to solve this by using maxim-lobanov/setup-xcode@v1
  • I'm not a fan of the name of XMLElementSendable... but it has to have a name
  • CHANGELOG

@drmohundro drmohundro force-pushed the feat/swift-6-support branch 15 times, most recently from b50f06d to d8837f8 Compare August 22, 2024 22:05
@drmohundro drmohundro force-pushed the feat/swift-6-support branch from 6223151 to 755147f Compare August 23, 2024 12:42
@drmohundro drmohundro force-pushed the feat/swift-6-support branch 2 times, most recently from e98b388 to 562bdff Compare September 17, 2024 22:54
I dropped old deprecation warnings as this is definitely a major version bump. For Swift 6 support, some of the types that were sent with errors are now wrapped in a "sendable" variety so that they're async safe.

The GitHub builds also heavily use matrix support for multiple platform builds now, too.
@drmohundro drmohundro marked this pull request as ready for review September 18, 2024 01:47
@drmohundro drmohundro changed the title feat: Swift 6 support feat: Swift 6 support and switch to swift-testing Sep 18, 2024
@drmohundro drmohundro merged commit 615f044 into main Sep 18, 2024
38 checks passed
@drmohundro drmohundro deleted the feat/swift-6-support branch September 18, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant