Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #145: Implement missing subject property #146

Merged
merged 1 commit into from
May 12, 2024
Merged

Fixes #145: Implement missing subject property #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/doctypes/simplewpml/simplewpml-base.rng
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@
<optional><element name="lastPrinted"><text/></element></optional>
<optional><element name="modified"><text/></element></optional>
<optional><element name="revision"><text/></element></optional>
<optional><element name="subject"><text/></element></optional>
<optional><element name="title"><text/></element></optional>
<optional><element name="version"><text/></element></optional>

Expand Down
2 changes: 2 additions & 0 deletions src/main/java/org/wordinator/xml2docx/generator/DocxGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ private void handleCoreProperties(XWPFDocument doc, XmlObject xml) {
}
} else if ("revision".equals(tagName)) {
coreProperties.setRevision(value);
} else if ("subject".equals(tagName)) {
coreProperties.setSubjectProperty(value);
} else if ("title".equals(tagName)) {
coreProperties.setTitle(value);
} else if ("version".equals(tagName)) {
Expand Down
5 changes: 5 additions & 0 deletions src/test/java/org/wordinator/xml2docx/TestDocxGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,11 @@ public void testDocumentPropertiesGeneration() throws Exception {
assertNotNull("Expected a value for 'revision' property", value);
assertEquals("Expected \"" + expected + "\", got \"" + value + "\"", expected, value);

value = coreProperties.getSubject();
expected = "subject value";
assertNotNull("Expected a value for 'subject' property", value);
assertEquals("Expected \"" + expected + "\", got \"" + value + "\"", expected, value);

value = coreProperties.getTitle();
expected = "Issue 140 Test of document properties";
assertNotNull("Expected a value for 'title' property", value);
Expand Down
1 change: 1 addition & 0 deletions src/test/resources/simplewp/simplewpml-issue-140-document-properties.swpx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
<lastPrinted>2024-04-21T10:11:12Z</lastPrinted>
<modified>2024-04-21T10:10:12Z</modified>
<revision>2</revision>
<subject>subject value</subject>
<title>Issue 140 Test of document properties</title>
<version>1</version>
</core-properties>
Expand Down