Support versions of GCS without transfer_manager #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## hotfix/v0.18.1-google-cloud-storage #410 +/- ##
=====================================================================
- Coverage 93.9% 93.9% -0.1%
=====================================================================
Files 23 23
Lines 1637 1643 +6
=====================================================================
+ Hits 1538 1543 +5
- Misses 99 100 +1
|
jmarshall
reviewed
Feb 26, 2024
|
I guess now I'm wondering if yanking v0.18.0 is necessary. It's a little hard to tell how severe of an action yanking is, and most of the examples given are worse errors. In the approach where we have a version floor, it's definitely necessary or v0.18.0 would be the newest version of cloudpathlib for I guess since this can cause an error on import just as a side-effect of having both packages installed, it probably doesn't hurt to still yank. |
jayqi
reviewed
Feb 26, 2024
Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
jayqi
approved these changes
Feb 26, 2024
pjbull
added a commit
that referenced
this pull request
Feb 26, 2024
* Fix 408 * Version and changelog * add warning * update history PR * Tweak description of change * Update HISTORY.md Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com> --------- Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
jayqi
added a commit
that referenced
this pull request
Feb 27, 2024
* Support versions of GCS without transfer_manager (#410) * Fix 408 * Version and changelog * add warning * update history PR * Tweak description of change * Update HISTORY.md Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com> --------- Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com> * Update HISTORY.md Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com> --------- Co-authored-by: Jay Qi <2721979+jayqi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
google-cloud-storage<2.7.0per discussion in #408 and #409.google-cloud-storage==2.6.0(and fails without the fix)transfer_managerkwargs that can't be used