Update to 2024 black style #396
Conversation
| @@ -1,5 +1,5 @@ | |||
| [flake8] | |||
| ignore = E731,E266,E501,C901,W503,E203 | |||
| ignore = E731,E266,E501,C901,W503,E203,E704 | |||
There was a problem hiding this comment.
As noted here, flake8's E704 conflicts with the new concise dummy implementation style
| @@ -1,6 +1,6 @@ | |||
| -e .[all] | |||
|
|
|||
| black[jupyter] | |||
| black[jupyter]>=24.1.0;python_version>='3.8' | |||
There was a problem hiding this comment.
Adding a floor here so that dev environments are consistent.
black has dropped Python 3.7. People shouldn't be doing dev in a 3.7 environment anyways, so skipping black here seems like a good workaround for us to keep the 3.7 tests going for a while.
We should probably consider dropping 3.7 support soon though.
This reverts commit aacbb5d.
| pytest | ||
| # pytest-cases | ||
| git+https://github.com/jayqi/python-pytest-cases@packaging-version | ||
| pytest<8 |
There was a problem hiding this comment.
pytest v8.0.0 literally just released hours ago, and there's some arcane looking error that is probably a pytest-cases incompatibility.
I opened an issue: smarie/python-pytest-cases#330
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
========================================
+ Coverage 93.8% 94.3% +0.4%
========================================
Files 22 22
Lines 1570 1560 -10
========================================
- Hits 1474 1472 -2
+ Misses 96 88 -8
|
Black release notes: https://github.com/psf/black/releases/tag/24.1.0
Closes #395
Bonus: Swap back to official pytest-cases. Closes #368